All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] ocfs2: bug in dlm_process_recovery_data()
Date: Tue, 9 Feb 2010 11:09:44 +0300	[thread overview]
Message-ID: <20100209080944.GA13283@bicker> (raw)

I noticed a change was merged to dlm_process_recovery_data() so I 
thought you might want to fix this as well.

fs/ocfs2/dlm/dlmrecovery.c
  1788                                  list_for_each_entry(lock, tmpq, list) {
  1789                                          if (lock->ml.cookie != ml->cookie)
  1790                                                  lock = NULL;

	We dereference lock in list_for_each_entry().  Maybe you want 
	list_for_each_entry_safe() or something?

  1791                                          else
  1792                                                  break;
  1793                                  }
  1794                                  if (lock)
  1795                                          break;

regards,
dan carpenter

             reply	other threads:[~2010-02-09  8:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-09  8:09 Dan Carpenter [this message]
2010-02-09 17:53 ` [Ocfs2-devel] ocfs2: bug in dlm_process_recovery_data() Sunil Mushran
2010-02-10 10:01   ` Dan Carpenter
2010-02-10 18:37     ` Sunil Mushran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100209080944.GA13283@bicker \
    --to=error27@gmail.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.