From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [PATCHv2] cld: use XDR for all messages
Date: Tue, 9 Feb 2010 17:21:57 -0700
Message-ID: <20100209172157.509ffdb9@redhat.com>
References: <1263577788-2081-1-git-send-email-cmccabe@alumni.cmu.edu>
	<4B7128FB.90600@garzik.org>
	<4B712D0D.5060408@garzik.org>
	<20100209161306.5e312b28@redhat.com>
	<4B71EDDE.6070209@garzik.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
In-Reply-To: <4B71EDDE.6070209@garzik.org>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Jeff Garzik <jeff@garzik.org>
Cc: Colin McCabe <cmccabe@alumni.cmu.edu>, Project Hail List <hail-devel@vger.kernel.org>

On Tue, 09 Feb 2010 18:21:02 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> So, the programs themselves have it right -- debug/verbose is an integer 
> not a bool.  The internal libraries get that wrong sometimes, though.
> 
> Having separate knobs for 'debug' and 'verbose' will be more confusing 
> than a single control, IMO.

I dunno, I think bigger packages tend to drift towards bitmasks.
But I don't have a strong opinion. I just wanted to restore the
per-packet output that you wanted. If you think that an integer is
better, that's fine. The newer code should is more regular and easier
to mold in any desired way.

Actually, I think the whole idea of debug levels is flawed.
We should work on adding a CLD protocol dissector to Wireshark
instead, now that with Colin's help we've settled to a protocol.

-- Pete