From: Stephen Hemminger <shemminger@vyatta.com>
To: Rasesh Mody <rmody@brocade.com>
Cc: netdev@vger.kernel.org, adapter_linux_open_src_team@brocade.com
Subject: Re: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver
Date: Wed, 10 Feb 2010 09:08:05 -0800 [thread overview]
Message-ID: <20100210090805.594b7007@nehalam> (raw)
In-Reply-To: <201002100629.o1A6TFUk026363@blc-10-10.brocade.com>
On Tue, 9 Feb 2010 22:29:15 -0800
Rasesh Mody <rmody@brocade.com> wrote:
> + BUG_ON(!(skb));
This driver seems to have lots of extra BUG_ON assertions
which implies either paranoia or still in development.
Putting in a check for NULL in places like this is not really
helpful. The check requires overhead, and will not provide any additional
help to the user. If the BUG_ON() is there the user will see
a backtrace and that cpu will be stuck ... if the BUG_ON was omitted,
and the skb was NULL, user would see a backtrace and cpu would
be stuck.
--
next prev parent reply other threads:[~2010-02-10 17:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 6:29 Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver Rasesh Mody
2010-02-10 17:08 ` Stephen Hemminger [this message]
2010-02-10 17:09 ` Stephen Hemminger
2010-02-10 17:10 ` Stephen Hemminger
2010-02-10 17:15 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2010-02-19 21:52 Rasesh Mody
2010-02-22 12:40 ` Stanislaw Gruszka
2010-02-12 14:00 Rasesh Mody
2009-12-19 1:28 Debashis Dutt
2009-12-19 7:14 ` Joe Perches
2009-11-26 9:28 Debashis Dutt
2009-11-24 3:51 Rasesh Mody
2009-11-17 8:30 Rasesh Mody
2009-11-17 8:59 ` David Miller
2009-11-13 3:46 Rasesh Mody
2009-11-01 5:03 Rasesh Mody
2009-11-01 5:23 ` Joe Perches
2009-11-01 19:25 ` Stephen Hemminger
2009-11-03 3:14 ` Debashis Dutt
2009-11-03 3:34 ` Greg KH
2009-11-03 18:24 ` Rasesh Mody
2009-11-04 0:31 ` Joe Perches
2009-11-01 8:02 ` Eric Dumazet
2009-11-03 7:54 ` Debashis Dutt
2009-11-01 19:19 ` Stephen Hemminger
2009-11-03 3:05 ` Debashis Dutt
2009-10-16 18:24 Rasesh Mody
2009-10-16 20:20 ` Ben Hutchings
2009-10-16 23:19 ` Rasesh Mody
2009-10-20 0:54 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210090805.594b7007@nehalam \
--to=shemminger@vyatta.com \
--cc=adapter_linux_open_src_team@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.