From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
hjl.tools@gmail.com
Subject: Re: [patch v2 2/4] x86, ptrace: regset extensions to support xstate
Date: Wed, 10 Feb 2010 11:44:30 +0100 [thread overview]
Message-ID: <20100210104430.GA4546@redhat.com> (raw)
In-Reply-To: <20100210013031.208FB73D8@magilla.sf.frob.com>
On 02/09, Roland McGrath wrote:
>
> > @@ -204,8 +209,6 @@ int xfpregs_set(struct task_struct *targ
> > if (ret)
> > return ret;
> >
> > - set_stopped_child_used_math(target);
> > -
>
> You didn't mention this change in a comment or log entry.
> It looks like it's superfluous after init_fpu. So this change
> is right, but AFAICT it belongs in an entirely separate patch
> and has nothing to do with xsave support.
I guess Suresh was going to change xstateregs_set() added by this patch,
it also sets USED_MATH after init_fpu().
Oleg.
next prev parent reply other threads:[~2010-02-10 10:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 20:13 [patch v2 0/4] updated ptrace/core-dump patches for supporting xstate - V2 Suresh Siddha
2010-02-09 20:13 ` [patch v2 1/4] revert "x86: ptrace and core-dump extensions for xstate" Suresh Siddha
2010-02-09 22:54 ` [tip:x86/ptrace] Revert " tip-bot for Suresh Siddha
2010-02-09 20:13 ` [patch v2 2/4] x86, ptrace: regset extensions to support xstate Suresh Siddha
2010-02-09 22:54 ` [tip:x86/ptrace] x86, ptrace: Regset " tip-bot for Suresh Siddha
2010-02-10 1:30 ` [patch v2 2/4] x86, ptrace: regset " Roland McGrath
2010-02-10 10:44 ` Oleg Nesterov [this message]
2010-02-10 11:28 ` Oleg Nesterov
2010-02-10 15:43 ` Oleg Nesterov
2010-02-10 18:26 ` Roland McGrath
2010-02-10 14:18 ` Oleg Nesterov
2010-02-10 15:34 ` Oleg Nesterov
2010-02-09 20:13 ` [patch v2 3/4] x86, ptrace: prepare regset get/set routines for user specified lengths Suresh Siddha
2010-02-09 22:55 ` [tip:x86/ptrace] x86, ptrace: Prepare " tip-bot for Suresh Siddha
2010-02-10 1:32 ` [patch v2 3/4] x86, ptrace: prepare " Roland McGrath
2010-02-09 20:13 ` [patch v2 4/4] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET Suresh Siddha
2010-02-09 22:55 ` [tip:x86/ptrace] " tip-bot for Suresh Siddha
2010-02-10 1:52 ` [patch v2 4/4] " Roland McGrath
2010-02-10 2:03 ` H.J. Lu
2010-02-10 3:07 ` Roland McGrath
2010-02-10 4:24 ` H.J. Lu
2010-02-10 13:18 ` Oleg Nesterov
2010-02-10 19:12 ` Roland McGrath
2010-02-11 2:17 ` H. Peter Anvin
2010-02-11 3:30 ` Roland McGrath
2010-02-10 1:12 ` [patch v2 0/4] updated ptrace/core-dump patches for supporting xstate - V2 Roland McGrath
2010-02-10 1:22 ` Suresh Siddha
2010-02-10 7:27 ` Ingo Molnar
2010-02-10 18:58 ` Roland McGrath
2010-02-11 2:18 ` H. Peter Anvin
2010-02-11 3:45 ` Roland McGrath
2010-02-11 4:16 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210104430.GA4546@redhat.com \
--to=oleg@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.