From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 5/6][cr-test][v2]: eclone-5: nr_pids must not exceed nesting level Date: Wed, 10 Feb 2010 09:47:05 -0600 Message-ID: <20100210154705.GC7254@us.ibm.com> References: <20100209193331.GB30005@us.ibm.com> <20100209193619.GD32274@us.ibm.com> <20100209211705.GA32631@us.ibm.com> <20100210012831.GA20795@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20100210012831.GA20795-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sukadev Bhattiprolu Cc: Containers List-Id: containers.vger.kernel.org Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org): > Serge E. Hallyn [serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org] wrote: > | Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org): > | > > | > From: Sukadev Bhattiprolu > | > Date: Mon, 1 Feb 2010 18:13:51 -0800 > | > Subject: [PATCH 5/6] eclone-5: nr_pids must not exceed nesting level > | > > | > Verify that eclone() fails if nr_pids exceeds the current nesting level > | > of pid namespaces. Also verify that eclone() succeeds in choosing a pid > | > for a process in a descendant pid namespace. > | > | This is a bit of a shame - it failed for me at first because I was > | running it inside a container. But there is no way for a task to > | know it's own nsdepth right? > > Nope - or at least I don't know of any way. > > We could modify the test to set nr_pids to a ridiculously large value > just to test that eclone() fails when nr_pids exceeds nesting level. Yeah though it's nice to be able to test the boundary conditions. I suppose it could take an optional nesting level argument - if not specified use 20. Then in documentation recommend that people run eclone-5 2 from init_pid_ns. The motivation would be to have the automated testing not return false positives! > | So I went ahead and pushed these tests (plus a few changes). > > Thanks, > > Sukadev