From: Arnd Bergmann <arnd@arndb.de>
To: Ed Swierk <eswierk@aristanetworks.com>
Cc: Sridhar Samudrala <sri@us.ibm.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 0/3 v4] macvtap driver
Date: Wed, 10 Feb 2010 15:52:03 +0100 [thread overview]
Message-ID: <201002101552.03722.arnd@arndb.de> (raw)
In-Reply-To: <1265685901.639.7.camel@localhost.localdomain>
On Tuesday 09 February 2010, Ed Swierk wrote:
> I've encountered some more problems, with various users of
> macvtap_file_get_queue() either calling or neglecting to call
> macvtap_file_put_queue() in error cases.
>
> I modified your patch so that when macvtap_file_get_queue() returns 0,
> it also calls rcu_read_unlock_bh(), and modified the users
> appropriately.
>
> This patch also incorporates my preemption fix for macvlan_count_rx().
>
> Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
Good idea, I'll incorporate it into my next fix, need to think
about it some more to make sure I catch all the corner cases
of the lifetime rules.
Thanks,
Arnd
next prev parent reply other threads:[~2010-02-10 14:52 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 10:04 [Bridge] [PATCH 0/3 v3] macvtap driver Arnd Bergmann
2010-01-27 10:04 ` Arnd Bergmann
2010-01-27 10:05 ` [Bridge] [PATCH 1/3] net: maintain namespace isolation between vlan and real device Arnd Bergmann
2010-01-27 10:05 ` Arnd Bergmann
2010-01-29 5:33 ` [Bridge] " David Miller
2010-01-29 5:33 ` David Miller
2010-01-29 10:12 ` [Bridge] " Arnd Bergmann
2010-01-29 10:12 ` Arnd Bergmann
2010-01-27 10:06 ` [Bridge] [PATCH 2/3] net/macvlan: allow multiple driver backends Arnd Bergmann
2010-01-27 10:06 ` Arnd Bergmann
2010-01-27 21:09 ` [Bridge] [PATCH 3/3] net: macvtap driver Arnd Bergmann
2010-01-27 21:09 ` Arnd Bergmann
2010-01-28 17:34 ` [Bridge] " Michael S. Tsirkin
2010-01-28 17:34 ` Michael S. Tsirkin
2010-01-28 20:18 ` [Bridge] " Arnd Bergmann
2010-01-28 20:18 ` Arnd Bergmann
2010-01-29 11:21 ` [Bridge] " Michael S. Tsirkin
2010-01-29 11:21 ` Michael S. Tsirkin
2010-01-29 19:49 ` [Bridge] " Arnd Bergmann
2010-01-29 19:49 ` Arnd Bergmann
2010-01-27 21:59 ` [Bridge] [PATCH 0/3 v3] " Arnd Bergmann
2010-01-27 21:59 ` Arnd Bergmann
2010-01-30 22:22 ` [Bridge] [PATCH 0/3 v4] " Arnd Bergmann
2010-01-30 22:22 ` Arnd Bergmann
2010-01-30 22:23 ` [Bridge] [PATCH 1/3] net: maintain namespace isolation between vlan and real device Arnd Bergmann
2010-01-30 22:23 ` Arnd Bergmann
2010-01-30 22:23 ` Arnd Bergmann
2010-01-30 22:23 ` [Bridge] [PATCH 2/3] macvlan: allow multiple driver backends Arnd Bergmann
2010-01-30 22:23 ` Arnd Bergmann
2010-01-30 22:23 ` Arnd Bergmann
2010-01-30 22:24 ` [Bridge] [PATCH 3/3] net: macvtap driver Arnd Bergmann
2010-01-30 22:24 ` Arnd Bergmann
2010-01-30 22:24 ` Arnd Bergmann
2010-02-04 4:21 ` [Bridge] [PATCH 0/3 v4] " David Miller
2010-02-04 4:21 ` David Miller
2010-02-08 17:14 ` Ed Swierk
2010-02-08 18:55 ` Sridhar Samudrala
2010-02-08 23:30 ` Ed Swierk
2010-02-10 14:50 ` Arnd Bergmann
2010-02-11 0:42 ` Ed Swierk
2010-02-11 7:12 ` Arnd Bergmann
2010-02-09 3:25 ` Ed Swierk
2010-02-10 14:52 ` Arnd Bergmann [this message]
2010-02-10 14:48 ` Arnd Bergmann
2010-02-10 18:05 ` Sridhar Samudrala
2010-02-10 18:10 ` Patrick McHardy
2010-02-11 15:45 ` [PATCH] net/macvtap: fix reference counting Arnd Bergmann
2010-02-11 15:55 ` [PATCH v2] " Arnd Bergmann
2010-02-11 21:09 ` Sridhar Samudrala
2010-02-16 5:53 ` David Miller
2010-02-18 15:44 ` Arnd Bergmann
2010-02-18 15:45 ` [PATCH 1/3] macvtap: rework object lifetime rules Arnd Bergmann
2010-02-18 20:09 ` Sridhar Samudrala
2010-02-18 22:11 ` David Miller
2010-02-18 15:46 ` [PATCH 2/3] net/macvtap: add vhost support Arnd Bergmann
2010-02-18 20:10 ` Sridhar Samudrala
2010-02-18 22:11 ` David Miller
2010-02-18 15:48 ` [PATCH 3/3] macvtap: add GSO/csum offload support Arnd Bergmann
2010-02-18 20:38 ` Sridhar Samudrala
2010-02-18 22:11 ` David Miller
2010-02-12 20:58 ` [PATCH v2] net/macvtap: fix reference counting Ed Swierk
2010-02-04 4:21 ` [PATCH 0/3 v4] macvtap driver David Miller
2010-01-30 22:22 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002101552.03722.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=eswierk@aristanetworks.com \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.