From: Jerome Glisse <glisse@freedesktop.org>
To: "Oldřich Jedlička" <oldium.pro@seznam.cz>
Cc: dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] drm/radeon/kms: Fix for CS track check to allow at least one enabled component
Date: Wed, 10 Feb 2010 23:58:58 +0100 [thread overview]
Message-ID: <20100210225858.GA8048@localhost.localdomain> (raw)
In-Reply-To: <201002102336.13227.oldium.pro@seznam.cz>
On Wed, Feb 10, 2010 at 11:36:12PM +0100, Oldřich Jedlička wrote:
> The current code causes failing of rendering (discovered on my KDE
> 4.4, mesa git master, xorg-video-ati git master) with message:
>
> r600_cs_track_check:252 mask 0x0000000F | 0xFFFFFFFF no cb for 1
>
> The problem is in the check of "at least one component is enabled" in
> r600_cs_track_check() - it finds the first component and does not check
> the rest. My patch fixes this by introducing is_valid local variable
> and checking all enabled components. The check returns failure only
> when there is really no component enabled.
>
> Signed-off-by: Oldřich Jedlička <oldium.pro@seznam.cz>
Already fixed in the newer version, also your patch defeated the
purpose of the checker. To work around this i only trust cb_target_mask.
Thanks for reporting this issue.
Cheers,
Jerome
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
prev parent reply other threads:[~2010-02-10 22:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 22:36 [PATCH] drm/radeon/kms: Fix for CS track check to allow at least one enabled component Oldřich Jedlička
2010-02-10 22:45 ` Oldřich Jedlička
2010-02-10 22:54 ` [PATCH v2] " Oldřich Jedlička
2010-02-11 17:19 ` Oldřich Jedlička
2010-02-10 22:58 ` Jerome Glisse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210225858.GA8048@localhost.localdomain \
--to=glisse@freedesktop.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=oldium.pro@seznam.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.