From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Bob Rodgers <Robert_Rodgers@dell.com>,
"lenb@kernel.org" <lenb@kernel.org>,
Linux-kernel <linux-kernel@vger.kernel.org>,
Louis Davis <Louis_Davis@dell.com>,
Jim Dailey <Jim_Dailey@dell.com>,
Michael Brown <Michael_E_Brown@dell.com>,
Mario Limonciello <Mario_Limonciello@dell.com>,
Matt Domsch <Matt_Domsch@dell.com>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] Add Dell Business Class Netbook LED driver
Date: Thu, 11 Feb 2010 18:31:03 +0000 [thread overview]
Message-ID: <20100211183103.GB2605@srcf.ucam.org> (raw)
In-Reply-To: <20100211182829.GA26659@core.coreip.homeip.net>
On Thu, Feb 11, 2010 at 10:28:30AM -0800, Dmitry Torokhov wrote:
> This is an opposite direction form the rest of the platform drivers
> which tend to combine functionality on per-vendor basis in one driver.
I don't think that's true - we /tend/ to see one driver per ACPI device
or device interface (see the dell-wmi/dell-laptop split, for instance).
> I'd say that in this case with this LED driver overhead on DELL systems
> not supportinfg it is miniscule. The benefit is that all vendor-specific
> sub-devices are children of one parent platform device.
I really don't see that as a strong benefit.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-02-11 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 20:49 [PATCH] Add Dell Business Class Netbook LED driver Bob Rodgers
2010-02-11 17:59 ` Richard Purdie
2010-02-11 18:05 ` Dmitry Torokhov
2010-02-11 18:07 ` Matthew Garrett
2010-02-11 18:28 ` Dmitry Torokhov
2010-02-11 18:31 ` Matthew Garrett [this message]
2010-02-11 18:09 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100211183103.GB2605@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Jim_Dailey@dell.com \
--cc=Louis_Davis@dell.com \
--cc=Mario_Limonciello@dell.com \
--cc=Matt_Domsch@dell.com \
--cc=Michael_E_Brown@dell.com \
--cc=Robert_Rodgers@dell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=error27@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.