Re: [PATCH] netfilter: don't use INIT_RCU_HEAD()

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Thu, Feb 11, 2010 at 09:49:11PM +0200, Alexey Dobriyan wrote:
> call_rcu() will unconditionally reinitialize RCU head anyway.

Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  net/netfilter/nf_conntrack_expect.c |    1 -
>  net/netfilter/nf_conntrack_extend.c |    1 -
>  net/netfilter/nfnetlink_queue.c     |    1 -
>  3 files changed, 3 deletions(-)
> 
> --- a/net/netfilter/nf_conntrack_expect.c
> +++ b/net/netfilter/nf_conntrack_expect.c
> @@ -232,7 +232,6 @@ struct nf_conntrack_expect *nf_ct_expect_alloc(struct nf_conn *me)
> 
>  	new->master = me;
>  	atomic_set(&new->use, 1);
> -	INIT_RCU_HEAD(&new->rcu);
>  	return new;
>  }
>  EXPORT_SYMBOL_GPL(nf_ct_expect_alloc);
> --- a/net/netfilter/nf_conntrack_extend.c
> +++ b/net/netfilter/nf_conntrack_extend.c
> @@ -59,7 +59,6 @@ nf_ct_ext_create(struct nf_ct_ext **ext, enum nf_ct_ext_id id, gfp_t gfp)
>  	if (!*ext)
>  		return NULL;
> 
> -	INIT_RCU_HEAD(&(*ext)->rcu);
>  	(*ext)->offset[id] = off;
>  	(*ext)->len = len;
> 
> --- a/net/netfilter/nfnetlink_queue.c
> +++ b/net/netfilter/nfnetlink_queue.c
> @@ -112,7 +112,6 @@ instance_create(u_int16_t queue_num, int pid)
>  	inst->copy_mode = NFQNL_COPY_NONE;
>  	spin_lock_init(&inst->lock);
>  	INIT_LIST_HEAD(&inst->queue_list);
> -	INIT_RCU_HEAD(&inst->rcu);
> 
>  	if (!try_module_get(THIS_MODULE)) {
>  		err = -EAGAIN;
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html