From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH 2/2] Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug Date: Fri, 12 Feb 2010 09:05:37 +0100 Message-ID: <201002120905.39403.Christoph.Egger@amd.com> References: <201002111859.43292.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Jiang, Yunhong" Cc: "Liu, Jinsong" , "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org Ah, I see. Thanks for clarification. Christoph On Friday 12 February 2010 02:51:03 Jiang, Yunhong wrote: > I think this is more about a regression. Originally hvmloader only create > 14 Processor definition in dsdt and the HVM_MAX_VCPUS is not used in that > code.Later, when the vCPU hotplug added, that 14 is changed to > HVM_MAX_VCPUS and cause regression. > > Thanks > --jyh > > >-----Original Message----- > >From: Christoph Egger [mailto:Christoph.Egger@amd.com] > >Sent: Friday, February 12, 2010 2:00 AM > >To: xen-devel@lists.xensource.com > >Cc: Liu, Jinsong; Jiang, Yunhong; Keir Fraser > >Subject: Re: [Xen-devel] [PATCH 2/2] Vcpu hotplug: change HVM_MAX_VCPUS to > > 15, and fix a small bug > > > >On Thursday 11 February 2010 18:40:58 Liu, Jinsong wrote: > >> Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug > >> > >> Win2000 will BSOD if cpus > 15, in order to compatible support win2000 > >> HVM, this patch change HVM_MAX_VCPUS to 15. This patch also fix a small > >> bug related to HVM_MAX_VCPUS. > >> > >> Signed-off-by: Liu, Jinsong > > > >This patch makes no sense to me. > >Didn't win2000 crash before the number of HVM_MAX_VCPUS > >has been increased from 32 to 128 ? > > > >Christoph > > > > > >-- > >---to satisfy European Law for business letters: > >Advanced Micro Devices GmbH > >Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen > >Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni > >Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen > >Registergericht Muenchen, HRB Nr. 43632 -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632