All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH]: common/cmd_flash.c: bug-fix
Date: Fri, 12 Feb 2010 10:00:18 +0100	[thread overview]
Message-ID: <201002121000.18952.sr@denx.de> (raw)
In-Reply-To: <1B4B728CB312483CB5A7BE72ECC00C67@smartbridges.com>

On Friday 12 February 2010 09:31:17 Teh Kok How wrote:
> --- u-boot-2009.11.1.orig/common/cmd_flash.c    2010-01-25
> 16:35:12.000000000 +0800
> 
> +++ u-boot-2009.11.1.new/common/cmd_flash.c     2010-02-12
> 16:18:10.565540182 +0800
> 
> @@ -43,6 +43,7 @@
> 
> 
> 
>  #ifndef CONFIG_SYS_NO_FLASH
> 
>  extern flash_info_t flash_info[];      /* info for FLASH chips */
> 
> +extern struct mtd_device *current_mtd_dev;

Sorry, but your patch has several problems:

- What exactly are you trying to fix? Please add a small description
  on what's broken and how your patch fixes it.
- Patch adds empty line after each line
- Patch is line wrapped
- Signed-off-by line missing

Please see here for more details on creating and sending patches:

http://www.denx.de/wiki/view/U-Boot/Patches

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2010-02-12  9:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12  8:31 [U-Boot] [PATCH]: common/cmd_flash.c: bug-fix Teh Kok How
2010-02-12  9:00 ` Stefan Roese [this message]
2010-02-12  9:16 ` Teh Kok How
2010-02-12 10:19   ` Stefan Roese
2010-02-12 10:35   ` [U-Boot] [PATCH]: common/cmd_flash.c: Fix mtdparts usage in "erase" and "protect" Teh Kok How
2010-02-12 15:32     ` Wolfgang Denk
2010-02-12 15:27   ` [U-Boot] [PATCH]: common/cmd_flash.c: bug-fix Wolfgang Denk
2010-02-22  5:36     ` Teh Kok How
2010-02-22  8:28       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002121000.18952.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.