From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nfvfc-0005wJ-3O
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 08:34:56 -0500
Received: from [199.232.76.173] (port=38260 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nfvfb-0005vs-GE
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 08:34:55 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <yamahata@valinux.co.jp>) id 1Nfveh-00061c-6j
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 08:34:55 -0500
Received: from mail.valinux.co.jp ([210.128.90.3]:40822)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <yamahata@valinux.co.jp>) id 1Nfveg-00061U-D2
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 08:33:59 -0500
Date: Fri, 12 Feb 2010 22:34:34 +0900
From: Isaku Yamahata <yamahata@valinux.co.jp>
Message-ID: <20100212133434.GI11930@valinux.co.jp>
References: <20100212023134.GC11930@valinux.co.jp>
	<20100212125457.GH21947@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100212125457.GH21947@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] pci: introduce get_info_quirk callback.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On Fri, Feb 12, 2010 at 02:54:59PM +0200, Michael S. Tsirkin wrote:
> On Fri, Feb 12, 2010 at 11:31:34AM +0900, Isaku Yamahata wrote:
> > This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5
> > by introducing device specific get_info_quirk callback.
> > It wrongly assumes that pci host bridge class device has
> > header type of pci-pci bridge. But this isn't always true.
> > In fact i440fx pci host bridge has header type of normal device,
> > hence it breaks i440fx and other pci host bridges.
> > The right fix is that header type should be checked, instead of device class.
> > 
> > The change set's purpose is to show PBM pci host bridge
> > info which doesn't conform to PCI specification.
> 
> So, PBM has header type PCI_HEADER_TYPE_NORMAL
> but all config space is in bridge format?

Some of registers is in bridge format.
To be honest, I don't know whether all or some.
Blue seems to want bus numbers registers at least.

http://lists.gnu.org/archive/html/qemu-devel/2010-02/msg00519.html
-- 
yamahata