From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH] virtio-spec: document MSI-X Date: Fri, 12 Feb 2010 20:17:55 +1030 Message-ID: <201002122017.55536.rusty@rustcorp.com.au> References: <20100211172236.GA20357@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: virtualization@lists.linux-foundation.org, markmc@redhat.com, Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from ozlabs.org ([203.10.76.45]:59697 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752122Ab0BLJsB (ORCPT ); Fri, 12 Feb 2010 04:48:01 -0500 In-Reply-To: <20100211172236.GA20357@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 12 Feb 2010 03:52:36 am Michael S. Tsirkin wrote: > This documents MSI-X support in virtio. > > Signed-off-by: Michael S. Tsirkin Wow, great! I reworked one paragraph for better grammar. Mainly adding "the": (pseudo-patch): Devices report such failures by returning +the+ NO_VECTOR value when the relevant Vector field is read. After mapping an event to vector, +the+ driver must verify success by reading the Vector field value: on success, +the+ previously written value is returned-;-+, and+ on failure, NO_VECTOR -value- is returned. If +a+ mapping failure is detected, +the+ driver can retry mapping with +fewer+-less- vectors, or disable MSI-X. I really liked the conversational style: standards can be intimidating and unfriendly documents if they concentrate too much on partitioning all information into precise sections. That makes it 0.8.6. I will re-read the entire document for consistency before releasing 0.9. Thanks! Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nfs8R-0000ch-TK for qemu-devel@nongnu.org; Fri, 12 Feb 2010 04:48:27 -0500 Received: from [199.232.76.173] (port=53313 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nfs8Q-0000cR-PS for qemu-devel@nongnu.org; Fri, 12 Feb 2010 04:48:26 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nfs8J-0006P6-SB for qemu-devel@nongnu.org; Fri, 12 Feb 2010 04:48:26 -0500 Received: from mx20.gnu.org ([199.232.41.8]:56451) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nfs8I-0006K0-UK for qemu-devel@nongnu.org; Fri, 12 Feb 2010 04:48:19 -0500 Received: from ozlabs.org ([203.10.76.45]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nfs8F-00079C-HO for qemu-devel@nongnu.org; Fri, 12 Feb 2010 04:48:15 -0500 From: Rusty Russell Date: Fri, 12 Feb 2010 20:17:55 +1030 References: <20100211172236.GA20357@redhat.com> In-Reply-To: <20100211172236.GA20357@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201002122017.55536.rusty@rustcorp.com.au> Subject: [Qemu-devel] Re: [PATCH] virtio-spec: document MSI-X List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: markmc@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org On Fri, 12 Feb 2010 03:52:36 am Michael S. Tsirkin wrote: > This documents MSI-X support in virtio. > > Signed-off-by: Michael S. Tsirkin Wow, great! I reworked one paragraph for better grammar. Mainly adding "the": (pseudo-patch): Devices report such failures by returning +the+ NO_VECTOR value when the relevant Vector field is read. After mapping an event to vector, +the+ driver must verify success by reading the Vector field value: on success, +the+ previously written value is returned-;-+, and+ on failure, NO_VECTOR -value- is returned. If +a+ mapping failure is detected, +the+ driver can retry mapping with +fewer+-less- vectors, or disable MSI-X. I really liked the conversational style: standards can be intimidating and unfriendly documents if they concentrate too much on partitioning all information into precise sections. That makes it 0.8.6. I will re-read the entire document for consistency before releasing 0.9. Thanks! Rusty.