All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>
Cc: Shirley Ma <mashirle@us.ibm.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/6] virtio: Initialize vq->data entries to NULL
Date: Fri, 12 Feb 2010 20:28:55 +1030	[thread overview]
Message-ID: <201002122028.55869.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1265950939-12359-2-git-send-email-amit.shah@redhat.com>

On Fri, 12 Feb 2010 03:32:14 pm Amit Shah wrote:
> vq operations depend on vq->data[i] being NULL to figure out if the vq
> entry is in use.
> 
> We have to initialize them to NULL to ensure we don't work with junk
> data and trigger false BUG_ONs.

Not really.  We wouldn't detect some bogus get_buf() calls if it's not NULL,
but we only *need* this since detach_bufs was added.

I've updated the commit message to reflect it.

Thanks,
Rusty.

  parent reply	other threads:[~2010-02-12  9:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12  5:02 [PATCH 0/6] virtio: console: Fixes Amit Shah
2010-02-12  5:02 ` [PATCH 1/6] virtio: Initialize vq->data entries to NULL Amit Shah
2010-02-12  5:02   ` [PATCH 2/6] virtio: console: Ensure no memleaks in case of unused buffers Amit Shah
2010-02-12  5:02     ` [PATCH 3/6] virtio: console: Add ability to remove module Amit Shah
2010-02-12  5:02       ` [PATCH 4/6] virtio: console: Error out if we can't allocate buffers for control queue Amit Shah
2010-02-12  5:02         ` [PATCH 5/6] virtio: console: Fill ports' entire in_vq with buffers Amit Shah
2010-02-12  5:02           ` [PATCH 6/6] Add MAINTAINERS entry for virtio_console Amit Shah
2010-02-12  9:58   ` Rusty Russell [this message]
2010-02-12  9:04 ` [PATCH 0/6] virtio: console: Fixes Rusty Russell
2010-02-12  9:07   ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002122028.55869.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=amit.shah@redhat.com \
    --cc=mashirle@us.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.