From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: vt6655: rewrite CARDvUpdateBasicTopRate()
Date: Sat, 13 Feb 2010 10:06:16 +0000 [thread overview]
Message-ID: <20100213100616.GK14210@bicker> (raw)
In-Reply-To: <20100213080317.GJ14210@bicker>
On Sat, Feb 13, 2010 at 10:44:53AM +0100, Jiri Slaby wrote:
> On 02/13/2010 10:36 AM, Jiri Slaby wrote:
> > You cannot use ffs and fls here.
>
> Actually you can (fls), if you add proper masks there like
> fls(pDevice->wBasicRate & ((1 << RATE_24M) - 1) & ~((1 << RATE_6M) -
> 1)), but with some macro-ification inside. Dunno if it gets better though.
>
Ok. I didn't understand how ffs() and fls() worked before. Sorry about that.
Let's just apply my original patch because that is an obvious one.
If I could test my changes, I would feel more comfortable rewriting stuff
but I don't have the hardware.
regards,
dan carpenter
> --
> js
prev parent reply other threads:[~2010-02-13 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 8:03 [patch] staging: vt6655: rewrite CARDvUpdateBasicTopRate() Dan Carpenter
2010-02-13 9:36 ` Jiri Slaby
2010-02-13 9:44 ` Jiri Slaby
2010-02-13 10:06 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100213100616.GK14210@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.