From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NggH4-0008IX-MU for qemu-devel@nongnu.org; Sun, 14 Feb 2010 10:20:42 -0500 Received: from [199.232.76.173] (port=55328 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NggH4-0008IB-6G for qemu-devel@nongnu.org; Sun, 14 Feb 2010 10:20:42 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NggH1-0007vL-NX for qemu-devel@nongnu.org; Sun, 14 Feb 2010 10:20:41 -0500 Received: from mx20.gnu.org ([199.232.41.8]:15708) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NggH1-0007vH-Gy for qemu-devel@nongnu.org; Sun, 14 Feb 2010 10:20:39 -0500 Received: from ol.freeshell.org ([192.94.73.20] helo=sdf.lonestar.org) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NggH0-0003Bw-M2 for qemu-devel@nongnu.org; Sun, 14 Feb 2010 10:20:39 -0500 Date: Sun, 14 Feb 2010 15:19:03 +0000 From: Jacob Meuser Message-ID: <20100214151903.GA13742@SDF.LONESTAR.ORG> References: <4B77E6CF.7000901@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B77E6CF.7000901@redhat.com> Subject: [Qemu-devel] Re: [PATCH] Give sdl-config higher priority than pkg-config List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Blue Swirl , Jacob Meuser , qemu-devel On Sun, Feb 14, 2010 at 01:04:31PM +0100, Paolo Bonzini wrote: > On 02/14/2010 08:23 AM, Blue Swirl wrote: > >On OpenBSD, pkg-config sdl --cflags forgets to add -I/usr/local/include > >which is needed for iconv.h (included from SDL.h). This makes SDL > >detection fail. > > > >Try sdl-config first, only if it fails try pkg-config. > > This breaks cross-compilation. I'm CCing the OpenBSD package > maintainer so that he can fix it. > > Upstream SDL has > > --cflags) > echo -I@includedir@/SDL @SDL_CFLAGS@ > ;; > > in sdl-config.in and > > Cflags: -I${includedir}/SDL @SDL_CFLAGS@ > > in sdl.pc.in, while OpenBSD has different values, so he modified > sdl-config apparently but not sdl.pc.in. that was done before I became maintainer. anyway, I'll fix it after ports unlocks. thanks for the notice. -- jakemsr@sdf.lonestar.org SDF Public Access UNIX System - http://sdf.lonestar.org