From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Michael Lukashov <michael.lukashov@gmail.com>,
Daniel Barkalow <barkalow@iabervon.org>,
git@vger.kernel.org
Subject: Re: [PATCH 1/4] Refactoring: remove duplicated code from transport.c and builtin-send-pack.c
Date: Mon, 15 Feb 2010 10:46:43 +0200 [thread overview]
Message-ID: <20100215084643.GA26012@Knoppix> (raw)
In-Reply-To: <20100215075514.GB5347@coredump.intra.peff.net>
On Mon, Feb 15, 2010 at 02:55:15AM -0500, Jeff King wrote:
> On Sun, Feb 14, 2010 at 10:34:20PM -0800, Junio C Hamano wrote:
>
> Actually, I wonder if we can simply get rid of some of the calls in
> send-pack. I think that the code in send-pack isn't even called anymore
> via "git push"; it only gets called when you call send-pack directly.
Actually, its also seemingly called by git-remote-http(s) (at least it
contains references to "stateless RPC", which is related to smart HTTP).
> And arguably send-pack as plumbing shouldn't be generating all sorts of
> user-facing output. But it is a behavior change. I wonder if anybody
> actually calls send-pack directly anymore. It seems like even scripts
> use "git push" because of the transport agnosticism.
For non-stateless case, it seems that the only protocols builtin-send-pack
can deal with are ssh://, git:// and file://, it can't deal with any
sort of remote helper, not even one provoding smart transport.
-Ilari
next prev parent reply other threads:[~2010-02-15 8:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 21:27 [PATCH 1/4] Refactoring: remove duplicated code from transport.c and builtin-send-pack.c Michael Lukashov
2010-02-14 21:27 ` [PATCH 2/4] Refactoring: connect.c: move duplicated code to get_host_and_port Michael Lukashov
2010-02-15 21:11 ` Johannes Sixt
2010-02-14 21:27 ` [PATCH 3/4] Refactoring: move duplicated code from builtin-pack-objects.c and fast-import.c to object.c Michael Lukashov
2010-02-14 21:27 ` [PATCH 4/4] Refactoring: remove duplicated code from builtin-checkout.c and merge-recursive.c Michael Lukashov
2010-02-15 3:29 ` [PATCH 1/4] Refactoring: remove duplicated code from transport.c and builtin-send-pack.c Tay Ray Chuan
2010-02-15 5:28 ` Jeff King
2010-02-15 6:34 ` Junio C Hamano
2010-02-15 7:55 ` Jeff King
2010-02-15 8:46 ` Ilari Liusvaara [this message]
2010-02-15 18:25 ` Daniel Barkalow
[not found] ` <7v635zj8jr.fsf@alter.siamese.dyndns.org>
2010-02-15 17:30 ` Larry D'Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100215084643.GA26012@Knoppix \
--to=ilari.liusvaara@elisanet.fi \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michael.lukashov@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.