All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH cr-tests] file locks: don't report failed checkpoint as failure
Date: Mon, 15 Feb 2010 10:52:54 -0600	[thread overview]
Message-ID: <20100215165254.GA5482@us.ibm.com> (raw)

And report failure if checkpoint succeeds, bc it should not.

Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
 fileio/run-fcntltests.sh |   10 +++++++++-
 fileio/runtests.sh       |    3 +++
 2 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/fileio/run-fcntltests.sh b/fileio/run-fcntltests.sh
index 35be131..2a5f628 100755
--- a/fileio/run-fcntltests.sh
+++ b/fileio/run-fcntltests.sh
@@ -51,8 +51,16 @@ checkpoint()
 	$ECHO "\t- Checkpoint: $CHECKPOINT $pid \> $CHECKPOINT_FILE"
 	$CHECKPOINT $pid > $CHECKPOINT_FILE
 	ret=$?
+	# At the moment we expect failure because checkpoint
+	# of file locks is not supported
 	if [ $ret -ne 0 ]; then
-		$ECHO "***** FAIL: Checkpoint of $pid failed"
+		$ECHO "***** PASS: Checkpoint of $pid failed"
+		ps -efL |grep $TEST_CMD >> $SCRIPT_LOG
+		killall -9 `basename $TEST_CMD`
+		thaw
+		exit 0;
+	else
+		$ECHO "***** FAIL: Checkpoint of $pid did not fail"
 		ps -efL |grep $TEST_CMD >> $SCRIPT_LOG
 		killall -9 `basename $TEST_CMD`
 		thaw
diff --git a/fileio/runtests.sh b/fileio/runtests.sh
index b808927..cb633fb 100755
--- a/fileio/runtests.sh
+++ b/fileio/runtests.sh
@@ -7,15 +7,18 @@ echo
 
 echo
 echo "****** $0: Running test: filelock1"
+echo "****** (expect FAIL)"
 echo
 ./run-fcntltests.sh filelock1
 
 echo
 echo "****** $0: Running test: filelease1"
+echo "****** (expect FAIL)"
 echo
 ./run-fcntltests.sh filelease1
 
 echo
 echo "****** $0: Running test: fsetown1"
+echo "****** (expect FAIL)"
 echo
 ./run-fcntltests.sh fsetown1
-- 
1.6.3.3

                 reply	other threads:[~2010-02-15 16:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100215165254.GA5482@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.