From: Al Viro <viro@ZenIV.linux.org.uk>
To: Matt Helsley <matthltc@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 0/4] Check O_* flags set with fcntl() on anon_inode files.
Date: Mon, 15 Feb 2010 19:57:28 +0000 [thread overview]
Message-ID: <20100215195728.GX30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100215172635.GI3714@count0.beaverton.ibm.com>
On Mon, Feb 15, 2010 at 09:26:35AM -0800, Matt Helsley wrote:
> > > [PATCH 1/4] signalfd
> > > [PATCH 2/4] timerfd
> > > [PATCH 3/4] epoll
> > > [PATCH 4/4] eventfd
> > >
> > > I did not check the perf, kvm-vm, or kvm-vcpu uses of anon_inodes.
> >
> > Er... O_ASYNC is silently ignored for regular files as well, so any
> > userland code that tries to rely on fcntl() rejecting it is and always
> > had been badly b0rken.
>
> Of course. Did you mean to imply that the kernel shouldn't bother to
> reject these, or were you merely making an observation?
I'm wondering why should we start changing that behaviour and what makes
these 4 cases special?
next prev parent reply other threads:[~2010-02-15 19:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 0:27 [RFC][PATCH 0/4] Check O_* flags set with fcntl() on anon_inode files Matt Helsley
2010-02-14 0:27 ` [RFC][PATCH 1/4] anon_inode fcntl() checks: report failure for fcntl(F_SETFL) on signalfd Matt Helsley
2010-02-14 0:27 ` [RFC][PATCH 2/4] anon_inode fcntl() checks: report failure for fcntl(F_SETFL) on timerfd Matt Helsley
2010-02-14 0:27 ` [RFC][PATCH 3/4] anon_inode fcntl() checks: report failure for fcntl(F_SETFL) on epoll Matt Helsley
2010-02-14 0:27 ` [RFC][PATCH 4/4] anon_inode fcntl() checks: report failure for fcntl(F_SETFL) on eventfd Matt Helsley
2010-02-14 0:40 ` [RFC][PATCH 0/4] Check O_* flags set with fcntl() on anon_inode files Davide Libenzi
2010-02-14 3:52 ` Al Viro
2010-02-15 17:26 ` Matt Helsley
2010-02-15 19:57 ` Al Viro [this message]
2010-02-16 11:37 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100215195728.GX30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.