From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>,
Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: [PATCH] i2c: Build core and algo drivers with -Wshadow
Date: Tue, 16 Feb 2010 12:21:52 +0100 [thread overview]
Message-ID: <20100216122152.29dbbeb5@hyperion.delvare> (raw)
I like building with -Wshadow, it helps catch bugs or at least bad
choices in variable names.
Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
Any objection?
drivers/hwmon/Makefile | 1 +
drivers/i2c/Makefile | 1 +
drivers/i2c/algos/Makefile | 1 +
drivers/i2c/busses/Makefile | 1 +
drivers/i2c/chips/Makefile | 1 +
5 files changed, 5 insertions(+)
--- linux-2.6.33-rc8.orig/drivers/i2c/Makefile 2010-02-16 10:59:43.000000000 +0100
+++ linux-2.6.33-rc8/drivers/i2c/Makefile 2010-02-16 11:09:07.000000000 +0100
@@ -8,6 +8,7 @@ obj-$(CONFIG_I2C_SMBUS) += i2c-smbus.o
obj-$(CONFIG_I2C_CHARDEV) += i2c-dev.o
obj-y += busses/ chips/ algos/
+EXTRA_CFLAGS += -Wshadow
ifeq ($(CONFIG_I2C_DEBUG_CORE),y)
EXTRA_CFLAGS += -DDEBUG
endif
--- linux-2.6.33-rc8.orig/drivers/i2c/algos/Makefile 2009-06-10 05:05:27.000000000 +0200
+++ linux-2.6.33-rc8/drivers/i2c/algos/Makefile 2010-02-16 11:19:59.000000000 +0100
@@ -6,6 +6,7 @@ obj-$(CONFIG_I2C_ALGOBIT) += i2c-algo-bi
obj-$(CONFIG_I2C_ALGOPCF) += i2c-algo-pcf.o
obj-$(CONFIG_I2C_ALGOPCA) += i2c-algo-pca.o
+EXTRA_CFLAGS += -Wshadow
ifeq ($(CONFIG_I2C_DEBUG_ALGO),y)
EXTRA_CFLAGS += -DDEBUG
endif
--
Jean Delvare
next reply other threads:[~2010-02-16 11:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 11:21 Jean Delvare [this message]
[not found] ` <20100216122152.29dbbeb5-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-02-16 20:27 ` [PATCH] i2c: Build core and algo drivers with -Wshadow Wolfram Sang
[not found] ` <20100216202715.GC17428-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-02-16 21:53 ` Jean Delvare
[not found] ` <20100216225352.1c4c3893-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-02-17 13:35 ` Wolfram Sang
2010-02-17 13:44 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216122152.29dbbeb5@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.