From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Roland McGrath <roland@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86: ELF_PLAT_INIT() shouldn't worry about TIF_IA32
Date: Tue, 16 Feb 2010 15:24:01 +0100 [thread overview]
Message-ID: <20100216142401.GA18671@redhat.com> (raw)
In-Reply-To: <20100216140323.GD16448@redhat.com>
On 02/16, Oleg Nesterov wrote:
>
> #define ELF_PLAT_INIT(_r, load_addr) \
> -do { \
> - elf_common_init(¤t->thread, _r, 0); \
> - clear_thread_flag(TIF_IA32); \
> -} while (0)
> + elf_common_init(¤t->thread, _r, 0);
^
unneeded semicolon, sorry...
------------------------------------------------------------------------------
[PATCH 3/3] x86: ELF_PLAT_INIT() shouldn't worry about TIF_IA32
64bit vesrion of ELF_PLAT_INIT() clears TIF_IA32, but at this point it
must be already cleared by SET_PERSONALITY == set_personality_64bit.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
arch/x86/include/asm/elf.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- exec/arch/x86/include/asm/elf.h~3_ELF_PLAT_INIT_IA32 2010-01-31 13:57:24.000000000 +0100
+++ exec/arch/x86/include/asm/elf.h 2010-02-16 15:19:43.000000000 +0100
@@ -170,10 +170,7 @@ static inline void elf_common_init(struc
}
#define ELF_PLAT_INIT(_r, load_addr) \
-do { \
- elf_common_init(¤t->thread, _r, 0); \
- clear_thread_flag(TIF_IA32); \
-} while (0)
+ elf_common_init(¤t->thread, _r, 0)
#define COMPAT_ELF_PLAT_INIT(regs, load_addr) \
elf_common_init(¤t->thread, regs, __USER_DS)
prev parent reply other threads:[~2010-02-16 14:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 16:17 x86: get rid of the insane TIF_ABI_PENDING bit Oleg Nesterov
2010-02-15 16:23 ` H. Peter Anvin
2010-02-15 16:50 ` Oleg Nesterov
2010-02-15 18:06 ` H. Peter Anvin
2010-02-15 18:52 ` Oleg Nesterov
2010-02-15 19:07 ` H. Peter Anvin
2010-02-15 19:10 ` H. Peter Anvin
2010-02-15 19:41 ` Roland McGrath
2010-02-15 20:07 ` H. Peter Anvin
2010-02-15 21:14 ` Roland McGrath
2010-02-15 20:43 ` H. Peter Anvin
2010-02-15 21:05 ` Roland McGrath
2010-02-16 10:19 ` Oleg Nesterov
2010-02-16 10:23 ` Andi Kleen
2010-02-16 14:01 ` [PATCH 0/3] Was: " Oleg Nesterov
2010-02-16 14:02 ` [PATCH 1/3] x86: set_personality_ia32() misses force_personality32 Oleg Nesterov
2010-02-16 23:27 ` [tip:x86/urgent] " tip-bot for Oleg Nesterov
2010-02-16 14:02 ` [PATCH 2/3] x86: set_personality_ia32() abuses TS_COMPAT Oleg Nesterov
2010-02-16 15:40 ` Linus Torvalds
2010-02-16 17:16 ` Oleg Nesterov
2010-02-16 17:38 ` H. Peter Anvin
2010-02-16 17:44 ` Oleg Nesterov
2010-02-16 17:51 ` H. Peter Anvin
2010-02-17 15:40 ` Oleg Nesterov
2010-02-16 18:43 ` Linus Torvalds
2010-02-16 14:03 ` [PATCH 3/3] x86: ELF_PLAT_INIT() shouldn't worry about TIF_IA32 Oleg Nesterov
2010-02-16 14:24 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216142401.GA18671@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.