From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: Re: [RFC SWIOTLB-0.4] Date: Tue, 16 Feb 2010 18:37:38 -0500 Message-ID: <20100216233738.GA16710@phenom.dumpdata.com> References: <20100203110407H.fujita.tomonori@lab.ntt.co.jp> <1265216892-14230-1-git-send-email-konrad.wilk@oracle.com> <20100204091718T.fujita.tomonori@lab.ntt.co.jp> <20100204030749.GB15580@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20100204030749.GB15580@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: FUJITA Tomonori Cc: Ian.Campbell@eu.citrix.com, jeremy@goop.org, xen-devel@lists.xensource.com, chrisw@sous-sol.org, iommu@lists.linux-foundation.org, dwmw2@infradead.org, alex.williamson@hp.com List-Id: xen-devel@lists.xenproject.org On Wed, Feb 03, 2010 at 10:07:49PM -0500, Konrad Rzeszutek Wilk wrote: > On Thu, Feb 04, 2010 at 09:17:31AM +0900, FUJITA Tomonori wrote: > > On Wed, 3 Feb 2010 12:08:01 -0500 > > Konrad Rzeszutek Wilk wrote: > > > > > Attached is a set of eleven RFC patches that split the SWIOTLB library in > > > two layers: core, and dma_ops related functions. > > > > What's the point of splitting swiotlb.c? Why can't you just export > > some of functions in swiotlb.c? > > I was emulating some of the other libraries that are in the kernel, > where the core functionality was in -core.c file and the users of it > are in subsequent once (libata). Thought there is one thing Jens Axboe mentioned that I didn't think off: Keep it as simple and as few. I've redone the patches, this time without the splitting and have exported the symbols. The git tree is: git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb-2.6.git swiotlb-0.5 And the LKML posting is: https://lists.linux-foundation.org/pipermail/iommu/2010-February/002066.html > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/iommu