All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Glisse <glisse@freedesktop.org>
To: Ladislav Kunc <L.Kunc@sh.cvut.cz>
Cc: Jerome Glisse <jglisse@redhat.com>, dri-devel@lists.sf.net
Subject: Re: [PATCH 1/2] drm/radeon/kms: fix indirect buffer management V2
Date: Wed, 17 Feb 2010 10:36:01 +0100	[thread overview]
Message-ID: <20100217093601.GA19952@localhost.localdomain> (raw)
In-Reply-To: <58e4e11b34d6548df5a9589e1e7556fd@localhost>

On Tue, Feb 16, 2010 at 11:30:52PM +0100, Ladislav Kunc wrote:
> 
> On Mon, 15 Feb 2010 21:36:13 +0100, Jerome Glisse <jglisse@redhat.com>
> wrote:
> > There is 3 different distinct states for an indirect buffer (IB) :
> >   1- free with no fence
> >   2- free with a fence
> >   3- non free (fence doesn't matter)
> > Previous code mixed case 2 & 3 in a single one leading to possible
> > catastrophique failure. This patch rework the handling and properly
> > separate each case. So when you get ib we set the ib as non free and
> > fence status doesn't matter. Fence become active (ie has a meaning
> > for the ib code) once the ib is scheduled or free. This patch also
> > get rid of the alloc bitmap as it was overkill, we know go through
> > IB pool list like in a ring buffer as the oldest IB is the first
> > one the will be free.
> > 
> > Fix :
> > https://bugs.freedesktop.org/show_bug.cgi?id=26438
> > and likely other bugs.
> > 
> > V2 remove the scheduled list, it's useless now, fix free ib scanning
> 
> Hi,
> 
> thank you very much for your fix. It seems I get no more hard lockups. But
> I have quite a lot of radeon_fence_signaled warnings just after X start.
> See attachment
> 
> I use kernel-2.6.git from Linus with merged drm-radeon-testing.
> xf86-video-ati git and mesa git. Running KDE 4.4.0 on Gentoo with OpenGL
> composting turned on.
> 
> What could be the issue?
> 
> Best regards,
> 
> -- 
> Ladislav Kunc
> 
> 

Did you apply the other patch too ? If yes please attach full kernel
log containing the message you saw to a bug and send me bug url

Cheers,
Jerome

------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
--

  reply	other threads:[~2010-02-17  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-15 20:36 [PATCH 1/2] drm/radeon/kms: fix indirect buffer management V2 Jerome Glisse
2010-02-16 22:30 ` Ladislav Kunc
2010-02-17  9:36   ` Jerome Glisse [this message]
2010-02-17 10:40     ` Ladislav Kunc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100217093601.GA19952@localhost.localdomain \
    --to=glisse@freedesktop.org \
    --cc=L.Kunc@sh.cvut.cz \
    --cc=dri-devel@lists.sf.net \
    --cc=jglisse@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.