From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Avi Kivity <avi@redhat.com>,
kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/3] KVM: x86: Save&restore interrupt shadow mask
Date: Wed, 17 Feb 2010 12:54:35 -0200 [thread overview]
Message-ID: <20100217145435.GA15508@amt.cnet> (raw)
In-Reply-To: <20100217091007.GM2995@redhat.com>
On Wed, Feb 17, 2010 at 11:10:07AM +0200, Gleb Natapov wrote:
> On Wed, Feb 17, 2010 at 10:03:58AM +0100, Jan Kiszka wrote:
> > >
> > > Also, as Avi mentioned it would be better to avoid this. Is it not
> > > possible to disallow migration while interrupt shadow is present?
> >
> > Which means disallowing user space exists while the shadow it set? Or
> > should we introduce some flag for user space that tells it "do not
> > migration now, resume the guest till next exit"?
> >
> I think disabling migration is a slippery slope. Guest may abuse it. May
> be it will be hard to do with interrupt shadow, but the mechanism will be
> used for other cases too. I remember there was an argument that we
> should not migrate while vcpu is in a nested guest mode.
Agree that guest may abuse it. Better to save/restore
blocking-by-sti/by-mov-ss individually.
I was thinking the writeback of interrupt shadow / interruptibility state
would be too complicated (eg necessary to care about ordering, etc), but
now i see its handled in kernel (inject_pending_event and friends).
next prev parent reply other threads:[~2010-02-17 14:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 9:45 [PATCH 0/3] KVM: VCPU state extensions Jan Kiszka
2010-02-15 9:45 ` [PATCH 1/3] KVM: x86: Do not return soft events in vcpu_events Jan Kiszka
2010-02-15 9:45 ` [PATCH 2/3] KVM: x86: Save&restore interrupt shadow mask Jan Kiszka
2010-02-17 0:39 ` Marcelo Tosatti
2010-02-17 8:06 ` Zachary Amsden
2010-02-17 9:05 ` Gleb Natapov
2010-02-17 9:07 ` Jan Kiszka
2010-02-17 9:03 ` Jan Kiszka
2010-02-17 9:10 ` Gleb Natapov
2010-02-17 14:54 ` Marcelo Tosatti [this message]
2010-02-19 18:38 ` [PATCH 2/3 v3] " Jan Kiszka
2010-02-15 9:45 ` [PATCH 3/3] KVM: x86: Add support for saving&restoring debug registers Jan Kiszka
2010-02-22 12:34 ` [PATCH 0/3] KVM: VCPU state extensions Jan Kiszka
2010-02-22 12:45 ` Avi Kivity
2010-02-22 12:54 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217145435.GA15508@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.