From: Oleg Nesterov <oleg@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: samu.p.onkalo@nokia.com, linux-input@vger.kernel.org
Subject: Re: [PATCH] input: polldev can cause crash in case of polling disabled
Date: Wed, 17 Feb 2010 21:23:39 +0100 [thread overview]
Message-ID: <20100217202339.GA21840@redhat.com> (raw)
In-Reply-To: <20100217195044.GC15554@core.coreip.homeip.net>
On 02/17, Dmitry Torokhov wrote:
>
> It apppears that it is allowed to try to cancel work that has never been
> queued
Yes,
> and I believe that canceled or completed work should be exactly
> the same as never been queued work (which is apparently not the case
> currently).
And yes, currently this is not the case.
As I said, I agree that cancel() could clear ->data. Will this change
help? (in any case this change is not for 2.6.33)
But I don't see how "completed" can do this, please see my previous
email. Note that flush() can't do this too.
> Yes, it is certainly possible to work around the issue in every driver
> that may happen to shut down and re-create workqueue as needed. The
> question is whether it is the right thing to do.
I'd say, the question is whether we can improve this ;) Well, see above.
Oleg.
next prev parent reply other threads:[~2010-02-17 20:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 14:44 [PATCH] input: polldev can cause crash in case of polling disabled Samu Onkalo
2010-02-16 17:50 ` Dmitry Torokhov
2010-02-16 18:37 ` samu.p.onkalo
2010-02-16 21:43 ` Dmitry Torokhov
2010-02-17 8:15 ` samu.p.onkalo
2010-02-17 8:56 ` samu.p.onkalo
2010-02-17 9:47 ` Dmitry Torokhov
2010-02-17 17:03 ` Oleg Nesterov
2010-02-17 19:50 ` Dmitry Torokhov
2010-02-17 20:23 ` Oleg Nesterov [this message]
2010-02-17 20:54 ` Dmitry Torokhov
2010-02-19 12:15 ` Oleg Nesterov
2010-02-18 6:46 ` samu.p.onkalo
2010-02-17 16:28 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217202339.GA21840@redhat.com \
--to=oleg@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.