All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm@vger.kernel.org
Cc: avi@redhat.com, Marcelo Tosatti <"mtosa..."@redhat.com>
Subject: [patch uq/master 1/4] qemu: block SIGCHLD in vcpu thread(s)
Date: Wed, 17 Feb 2010 20:14:40 -0200	[thread overview]
Message-ID: <20100217221700.966865697@redhat.com> (raw)
In-Reply-To: 20100217221439.351652889@redhat.com

[-- Attachment #1: block-sigchld --]
[-- Type: text/plain, Size: 519 bytes --]

Otherwise a vcpu thread can run the sigchild handler causing
waitpid() from iothread to fail.

Signed-off-by: Marcelo Tosatti <mtosa...@redhat.com>

Index: qemu/vl.c
===================================================================
--- qemu.orig/vl.c
+++ qemu/vl.c
@@ -3514,6 +3514,7 @@ static void block_io_signals(void)
     sigaddset(&set, SIGUSR2);
     sigaddset(&set, SIGIO);
     sigaddset(&set, SIGALRM);
+    sigaddset(&set, SIGCHLD);
     pthread_sigmask(SIG_BLOCK, &set, NULL);
 
     sigemptyset(&set);



  reply	other threads:[~2010-02-17 22:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 22:14 [patch uq/master 0/4] uq/master: iothread consume signals via sigtimedwait and cleanups Marcelo Tosatti
2010-02-17 22:14 ` [Qemu-devel] " Marcelo Tosatti
2010-02-17 22:14 ` Marcelo Tosatti [this message]
2010-02-17 22:14 ` [patch uq/master 2/4] qemu: kvm specific wait_io_event Marcelo Tosatti
2010-02-17 22:14   ` [Qemu-devel] " Marcelo Tosatti
2010-02-18  8:29   ` Avi Kivity
2010-02-18 13:58     ` Marcelo Tosatti
2010-02-18 14:33       ` Avi Kivity
2010-02-17 22:14 ` [patch uq/master 3/4] qemu: kvm: consume internal signal with sigtimedwait Marcelo Tosatti
2010-02-17 22:14   ` [Qemu-devel] " Marcelo Tosatti
2010-02-17 22:14 ` [patch uq/master 4/4] qemu: kvm: remove pre-entry exit_request check with iothread enabled Marcelo Tosatti
2010-02-17 22:14   ` [Qemu-devel] " Marcelo Tosatti
2010-02-18  8:26 ` [patch uq/master 0/4] uq/master: iothread consume signals via sigtimedwait and cleanups Avi Kivity
2010-02-22  8:59 ` Avi Kivity
2010-02-22  8:59   ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100217221700.966865697@redhat.com \
    --to=mtosatti@redhat.com \
    --cc="mtosa..."@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.