All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel <g2p.code@gmail.com>
To: git@vger.kernel.org
Cc: Peter Krefting <peter@softwolves.pp.se>
Subject: Re: [PATCH] import-tars: properly import git-archive tarballs
Date: Thu, 18 Feb 2010 14:00:02 +0100	[thread overview]
Message-ID: <20100218140002.14f79853@gmail.com> (raw)
In-Reply-To: <1266434452-14532-1-git-send-email-g2p.code@gmail.com>

> Gabriel:
> > git-archive adds a special entry to the archives it creates, 
> > pax_global_header, containing the SHA1 of the exported commit.
> 
> Interesting use-case.

My use case really was a simple “import a range of tarballs for
bisecting”. That they were from git was a surprise, but I don't have
access to that repo, which for all I know is full of junk and not meant
for publication, so I'm not trying to get the original history.

I just want importing to work on tarballs found in the wild.

> > Now import-tars correctly ignores the comment.
> 
> In the case where you actually would care, perhaps it should be added
> as a comment to the default commit message? Something like "Imported
> from $tar_file, created from commit $commit.".

Someone with stronger perl-fu to parse the hash comment could print on
stderr (keep me CC-ed if you do that):
  This tarball was generated by git, from commit id $SHA1.

It will serve as a hint when the person doing the import has access to
the original history. I don't think there's a point in keeping a sha1
when there's no access; keeping it in the history would confuse people,
or require sticking a longer explanation to each of these commits.

  parent reply	other threads:[~2010-02-18 13:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 19:20 [PATCH] import-tars: properly import git-archive tarballs Gabriel
2010-02-18  9:40 ` Peter Krefting
2010-02-18 13:00 ` Gabriel [this message]
2010-02-18 13:24   ` [PATCH] import-tars: Make it possible to include the original commit ID Peter Krefting
2010-02-18 15:02     ` Gabriel
2010-02-19  8:12       ` Peter Krefting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100218140002.14f79853@gmail.com \
    --to=g2p.code@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peter@softwolves.pp.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.