All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 9/10] udlfb: explicit dependencies and warnings
Date: Thu, 18 Feb 2010 16:01:17 +0000	[thread overview]
Message-ID: <20100218160117.GF21785@kroah.com> (raw)
In-Reply-To: <1266245195.4353.3304.camel@bernie-aspireone>

On Mon, Feb 15, 2010 at 06:46:35AM -0800, Bernie Thompson wrote:
> Specify Kconfig dependencies, and include warnings for building as a module
> 
> udlfb is dependent on FB_DEFERRED_IO, FB_SYS_*, and FB_MODE_HELPERS
> 
> Because many kernels do not include defio (which cannot be built
> as a module), yet users want to be able to build udlfb as a module later,
> udlfb has ifdefs and these dependency warnings to help udlfb build with or
> without certain dependencies, but also print warnings for any lost function.
> 
> Even though this kind of flexibility isn't common, we've gotten feedback
> from a significant portion of users that they were frustrated without it.

This patch adds the warning to the build:
	drivers/staging/udlfb/udlfb.c:65:2: warning: #warning message "FB_SYS_* in kernel or module option to support fb console"

Any ideas?

thanks,

greg k-h

  reply	other threads:[~2010-02-18 16:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-15 14:46 [PATCH 9/10] udlfb: explicit dependencies and warnings Bernie Thompson
2010-02-18 16:01 ` Greg KH [this message]
2010-02-18 22:49 ` Bernie Thompson
2010-02-19  0:37 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100218160117.GF21785@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.