From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brad Boyer <flar@allandria.com>
Subject: Re: [PATCH 1/6] vfs: add per-sb auxiliary inode attribute table
Date: Thu, 18 Feb 2010 11:00:22 -0800
Message-ID: <20100218190022.GA1783@cynthia.pants.nu>
References: <1266511530-10533-1-git-send-email-dmonakhov@openvz.org> <1266511530-10533-2-git-send-email-dmonakhov@openvz.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
To: Dmitry Monakhov <dmonakhov@openvz.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from [76.245.85.235] ([76.245.85.235]:33827 "EHLO cynthia.pants.nu"
	rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1755334Ab0BRTAe (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 18 Feb 2010 14:00:34 -0500
Content-Disposition: inline
In-Reply-To: <1266511530-10533-2-git-send-email-dmonakhov@openvz.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Feb 18, 2010 at 07:45:25PM +0300, Dmitry Monakhov wrote:
> Some times it is useful to export non standard attributes
> to generic vfs layer, but it is too expansive to store it
> inside vfs inode. Let's introduce generic interface for this
> purpose. One may declare an attribute and filesystem provides
> access to it, if necessery.
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> @@ -1576,7 +1578,10 @@ struct super_operations {
>  #endif
>  	int (*bdev_try_to_free_page)(struct super_block*, struct page*, gfp_t);
>  };
> -
> +struct aux_attributes
> +{
> +	int supported;
> +};
>  /*
>   * Inode state bits.  Protected by inode_lock.
>   *
> -- 

What is the intended use of the supported field? You don't appear to use
it anywhere other than to initialize it to 1 in the one instance where
you create one of them.

	Brad Boyer
	flar@allandria.com