From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] ppc4xx: add support for alternate format for ndfc
Date: Fri, 19 Feb 2010 08:57:18 +0100 [thread overview]
Message-ID: <201002190857.18988.sr@denx.de> (raw)
In-Reply-To: <1266531913-20756-1-git-send-email-fkan@amcc.com>
Hi Feng,
On Thursday 18 February 2010 23:25:13 fkan at amcc.com wrote:
> From: Feng Kan <fkan@amcc.com>
>
> This is to lock down the ordering in the correction routine against
> the calculate routine. Otherwise, incorrect define would cause ECC errors.
It was my impression that we (finally) had done this ordering correct. The
last changes were upon your request:
68e74567cf317318df52dbcb2ac170ffc5e7758a:
ppc4xx: Fix ECC Correction bug with SMC ordering for NDFC driver
I don't see how this patch should fix a potential problem. Please explain
which problem exactly is fixed with this change. As Wolfgang already
mentioned, CONFIG_MTD_NAND_ECC_SMC will not be set in this file.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2010-02-19 7:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 22:25 [U-Boot] [PATCH 1/1] ppc4xx: add support for alternate format for ndfc fkan at amcc.com
2010-02-18 23:13 ` Wolfgang Denk
2010-02-19 0:08 ` Feng Kan
2010-02-19 8:45 ` Wolfgang Denk
2010-02-19 7:57 ` Stefan Roese [this message]
2010-02-19 18:27 ` Feng Kan
2010-02-22 10:52 ` Stefan Roese
2010-02-22 18:06 ` Feng Kan
2010-02-22 20:54 ` Wolfgang Denk
2010-02-23 5:13 ` Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002190857.18988.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.