From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Michael D Labriola <mlabriol@gdeb.com>,
Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com, xen-devel-bounces@lists.xensource.com
Subject: Re: PCI passthrough w/ shared IRQ in xen/master
Date: Fri, 19 Feb 2010 16:45:08 -0500 [thread overview]
Message-ID: <20100219214508.GA13581@phenom.dumpdata.com> (raw)
In-Reply-To: <OF050DF4D7.ECD5A23E-ON852576CF.0069869D-852576CF.0069B54B@gdeb.com>
> > > There is a missing patch that I haven't pushed in the pcifront branch:
> > >
> > > diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> > > index e138053..923de2e 100644
> > > --- a/arch/x86/pci/xen.c
> > > +++ b/arch/x86/pci/xen.c
> > > @@ -25,7 +25,7 @@ static int xen_pcifront_enable_irq(struct pci_dev
> > *dev)
> > > if (dev->irq < 0)
> > > return -EINVAL;
> > >
> > > - rc = xen_allocate_pirq(dev->irq, 0, "pcifront");
> > > + rc = xen_allocate_pirq(dev->irq, 1 /* share */, "pcifront");
> > > if (rc < 0) {
> > > dev_warn(&dev->dev, "Xen PCI IRQ: %d, failed to register:%d\n",
> > > dev->irq, rc);
> > >
> > >
> >
> >
> > HA! That's an important one-line diff! Now my ATM card works w/ shared
>
> > IRQ on domU. :-)
> >
> > Now we just have to get a better fix for dom0 than commenting out the
> > entire note_interrupt() function...
>
> Actually, I just verified that that patch makes the note_interrupt()
> gutting unnecessary. With just that one line changed, I'm up and running
> perfectly.
Excellent.
Jeremy, could you pull
git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git pcifront-2.6.31.6
in your xen/pcifront and merge it to xen/master, please?
next prev parent reply other threads:[~2010-02-19 21:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 15:56 PCI passthrough w/ shared IRQ in xen/master Michael D Labriola
2010-02-19 16:06 ` Keir Fraser
2010-02-19 16:14 ` Michael D Labriola
2010-02-19 16:29 ` Stefan Kuhne
2010-02-19 16:15 ` Mark Hurenkamp
2010-02-19 16:24 ` Keir Fraser
2010-02-19 16:26 ` Michael D Labriola
2010-02-19 16:55 ` Michael D Labriola
2010-02-19 17:17 ` Keir Fraser
2010-02-19 17:25 ` Michael D Labriola
2010-02-19 16:24 ` Michael D Labriola
2010-02-19 17:07 ` Konrad Rzeszutek Wilk
2010-02-19 17:49 ` Michael D Labriola
2010-02-19 18:27 ` Stefan Kuhne
2010-02-19 18:51 ` Stefan Kuhne
2010-02-19 19:14 ` Michael D Labriola
2010-02-19 21:30 ` Keir Fraser
2010-02-19 21:45 ` Konrad Rzeszutek Wilk [this message]
2010-02-19 22:32 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219214508.GA13581@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=jeremy@goop.org \
--cc=mlabriol@gdeb.com \
--cc=xen-devel-bounces@lists.xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.