From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 3/3] af_key: locking change Date: Fri, 19 Feb 2010 21:53:14 -0800 Message-ID: <20100219215314.66d6f857@nehalam> References: <20100219215913.819285957@vyatta.com> <20100219220111.868268353@vyatta.com> <1266638850.2839.6.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alexander Viro , Andrew Morton , Rusty Russell , Peter Oberparleiter , Miklos Szeredi , "Paul E. McKenney" , "David S. Miller" , Jiri Pirko , Jiri Olsa , Ingo Molnar , Alexey Dobriyan , Jamal Hadi Salim , Neil Horman , netdev@vger.kernel.org To: Eric Dumazet Return-path: Received: from mail.vyatta.com ([76.74.103.46]:54091 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929Ab0BTFxt convert rfc822-to-8bit (ORCPT ); Sat, 20 Feb 2010 00:53:49 -0500 In-Reply-To: <1266638850.2839.6.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 20 Feb 2010 05:07:30 +0100 Eric Dumazet wrote: > Le vendredi 19 f=C3=A9vrier 2010 =C3=A0 13:59 -0800, Stephen Hemminge= r a =C3=A9crit : > > pi=C3=A8ce jointe document texte brut (pfkey-rcu.patch) > > Get rid of custom locking that was using wait queue, lock, and atom= ic > > to basically build a queued mutex. Use RCU for read side. > >=20 > > Signed-off-by: Stephen Hemminger >=20 > Excellent >=20 > Acked-by: Eric Dumazet >=20 > I dont know why you used synchronize_sched() instead of > synchronize_rcu(). I'll go back to synchronize_rcu. --=20