All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] ACPI thermal: Check for thermal zone requiremen
Date: Sat, 20 Feb 2010 11:15:21 +0100	[thread overview]
Message-ID: <201002201115.21988.trenn@suse.de> (raw)
In-Reply-To: <alpine.LFD.2.00.1002191108590.4030@localhost.localdomain>

Hi,

I haven't seen your post at then end of the mail...

On Friday 19 February 2010 05:20:51 pm Len Brown wrote:
> >
> > Related ASL output:
> >
> >
> > If (_OSI ("Linux"))
> >                 {
> >                     Store (One, LINX)
> >                     Store (0x80, OSTB)
> >                     Store (0x80, TPOS)
> >                 }
> > If (_OSI ("Windows 2006"))
> >                 {
> >                     Store (0x40, OSTB)
> >                     Store (0x40, TPOS)
> >                 }
> >
> > ...
> > Name (TPC, 0x64)
> > Method (_HOT, 0, Serialized)
> > {
> >     If (LEqual (TPOS, 0x40))
> >     {
> >         Return (Add (0x0AAC, Multiply (TPC, 0x0A)))
> >     }
> > }
> >
> > Method (_CRT, 0, Serialized)
> > {
> >     If (LNotEqual (TPOS, 0x40))
> >     {
> >         Return (Add (0x0AAC, Multiply (TPC, 0x0A)))
> >     }
> > }
>
> It appears that if acpi_osi=Linux were set (or TPOS were
> anything other than Windows 2006), then you
> would not get a _HOT or _CRT in this TZ.
> I don't understand how that is related to this issue,
> as acpi_osi=Linux is not set, right?
>
> acpi_osi="Windows 2006", on the other hand, should be set.
> In that case the AML will return a valid trip point for
> both _HOT and _CRT, yes?  So what is the problem?
The problem is that in:
      - _HOT it's a LEqual (TPOS, 0x40)
      - _CRT it's a LNotEqual (TPOS, 0x40)

You will get a valid hot tp on Windows 2006 (or newer) and an invalid critical 
one.
On all others you get an invalid hot, but a valid critical tp (which is also 
the case with osi=Linux).

      Thomas

  parent reply	other threads:[~2010-02-20 10:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16 21:55 [PATCH 1/2] ACPI thermal: Don't invalidate thermal zone if critical trip point is bad Thomas Renninger
2010-02-16 21:55 ` [PATCH 2/2] ACPI thermal: Check for thermal zone requirement Thomas Renninger
2010-02-19  6:39   ` [PATCH 2/2] ACPI thermal: Check for thermal zone requiremen Len Brown
2010-02-19 11:20     ` Thomas Renninger
2010-02-19 16:20       ` Len Brown
2010-02-19 16:37         ` Thomas Renninger
2010-02-20  4:57           ` Len Brown
2010-02-20  9:50             ` Thomas Renninger
2010-02-20 10:15         ` Thomas Renninger [this message]
2010-02-19  6:34 ` [PATCH 1/2] ACPI thermal: Don't invalidate thermal zone if critical trip point is bad Len Brown
2010-02-19  7:34   ` Len Brown
2010-02-20 10:20     ` [PATCH] " Thomas Renninger
2010-02-20 10:42       ` Thomas Renninger
2010-02-20 10:44 ` Thomas Renninger
2010-02-21  2:51   ` Zhang Rui
     [not found]     ` <201002220002.49341.trenn@suse.de>
2010-02-22  1:33       ` Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002201115.21988.trenn@suse.de \
    --to=trenn@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.