From: Dave Young <hidave.darkstar@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
David Howells <dhowells@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
James Morris <jmorris@namei.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 04/18] sysctl extern cleanup - binfmts
Date: Sat, 20 Feb 2010 22:10:23 +0800 [thread overview]
Message-ID: <20100220141023.GC3195@darkstar> (raw)
Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.
Move core_uses_pid/core_pattern/core_pipe_limit extern declarations
to linux/binfmts.h
suid_dumpable is declared in binfmts.h already.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
include/linux/binfmts.h | 6 ++++++
kernel/sysctl.c | 5 +----
2 files changed, 7 insertions(+), 4 deletions(-)
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-20 14:06:33.374900066 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-20 14:06:42.621567640 +0800
@@ -56,6 +56,7 @@
#include <linux/rcustring.h>
#include <linux/signal.h>
#include <linux/threads.h>
+#include <linux/binfmts.h>
#include <asm/uaccess.h>
#include <asm/processor.h>
@@ -70,10 +71,6 @@
#if defined(CONFIG_SYSCTL)
/* External variables not in a header file. */
-extern int core_uses_pid;
-extern int suid_dumpable;
-extern char *core_pattern;
-extern unsigned int core_pipe_limit;
extern int pid_max;
extern int min_free_kbytes;
extern int pid_max_min, pid_max_max;
--- linux-2.6.32.orig/include/linux/binfmts.h 2010-02-20 14:02:26.958258402 +0800
+++ linux-2.6.32/include/linux/binfmts.h 2010-02-20 14:06:42.621567640 +0800
@@ -20,6 +20,12 @@ struct pt_regs;
#ifdef __KERNEL__
#include <linux/list.h>
+#ifdef CONFIG_SYSCTL
+extern int core_uses_pid;
+extern char *core_pattern;
+extern unsigned int core_pipe_limit;
+#endif
+
#define CORENAME_MAX_SIZE 128
/*
reply other threads:[~2010-02-20 14:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100220141023.GC3195@darkstar \
--to=hidave.darkstar@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.