From: Dave Young <hidave.darkstar@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Gerd Hoffmann <kraxel@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Roland McGrath <roland@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, James Morris <jmorris@namei.org>
Subject: [PATCH 07/18] sysctl extern cleanup - compat
Date: Sat, 20 Feb 2010 22:13:28 +0800 [thread overview]
Message-ID: <20100220141328.GF3195@darkstar> (raw)
Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.
Move compat_log extern declaration to linux/compat.h
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
include/linux/compat.h | 3 +++
kernel/sysctl.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
--- linux-2.6.32.orig/include/linux/compat.h 2010-02-20 14:02:24.334925488 +0800
+++ linux-2.6.32/include/linux/compat.h 2010-02-20 14:24:30.405627048 +0800
@@ -17,6 +17,9 @@
#include <asm/siginfo.h>
#include <asm/signal.h>
+#ifdef CONFIG_SYSCTL
+extern int compat_log;
+#endif
#define compat_jiffies_to_clock_t(x) \
(((unsigned long)(x) * COMPAT_USER_HZ) / HZ)
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-20 14:13:28.511525875 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-20 14:23:58.042295739 +0800
@@ -58,6 +58,7 @@
#include <linux/threads.h>
#include <linux/binfmts.h>
#include <linux/pid.h>
+#include <linux/compat.h>
#include <asm/uaccess.h>
#include <asm/processor.h>
@@ -72,7 +73,6 @@
#if defined(CONFIG_SYSCTL)
/* External variables not in a header file. */
-extern int compat_log;
extern int latencytop_enabled;
extern int sysctl_nr_open_min, sysctl_nr_open_max;
#ifdef CONFIG_RCU_TORTURE_TEST
next reply other threads:[~2010-02-20 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 14:13 Dave Young [this message]
2010-02-20 14:51 ` [PATCH 07/18] sysctl extern cleanup - compat Arnd Bergmann
2010-02-20 15:16 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100220141328.GF3195@darkstar \
--to=hidave.darkstar@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=jmorris@namei.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.