From: Alexey Dobriyan <adobriyan@gmail.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
James Morris <jmorris@namei.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 03/17] sysctl extern cleanup - binfmts
Date: Sun, 21 Feb 2010 16:28:13 +0200 [thread overview]
Message-ID: <20100221142813.GB21281@core2> (raw)
In-Reply-To: <20100221142303.GA3004@darkstar>
On Sun, Feb 21, 2010 at 10:23:03PM +0800, Dave Young wrote:
> --- linux-2.6.32.orig/include/linux/binfmts.h
> +++ linux-2.6.32/include/linux/binfmts.h
> @@ -20,6 +20,11 @@ struct pt_regs;
> #ifdef __KERNEL__
> #include <linux/list.h>
>
> +/* for sysctl */
This comment is neither accurate nor needed. :^)
In fact master sysctl table always was a big mess, so slight mess
caused by extern declarations is fine.
> +extern int core_uses_pid;
> +extern char *core_pattern;
> +extern unsigned int core_pipe_limit;
next prev parent reply other threads:[~2010-02-21 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-21 14:23 [PATCH -mm 03/17] sysctl extern cleanup - binfmts Dave Young
2010-02-21 14:28 ` Alexey Dobriyan [this message]
2010-02-21 14:33 ` Dave Young
2010-02-21 14:36 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100221142813.GB21281@core2 \
--to=adobriyan@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hidave.darkstar@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.