From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Renninger <trenn@suse.de>
Cc: linux-acpi@vger.kernel.org, lenb@kernel.org, rui.zhang@intel.com
Subject: Re: [PATCH] ACPI video: Be more liberal in validating _BQC behaviour
Date: Mon, 22 Feb 2010 17:38:36 +0000 [thread overview]
Message-ID: <20100222173836.GA24808@srcf.ucam.org> (raw)
In-Reply-To: <201002221824.16920.trenn@suse.de>
On Mon, Feb 22, 2010 at 06:24:16PM +0100, Thomas Renninger wrote:
> Can you use:
> printk(KERN_WARNING FW_WARN "%s returned an invalid level", buf);
> instead please.
> It would be great if major kernel contributors, especially those working
> near the BIOS do make use of the FW_* strings more often!
I could, but I don't see there being any real benefit in doing so while
the rest of the file doesn't make use of it. It seems like a reasonable
thing to do in a followup patch.
> Cleaning up existing messages is one (work intensive) thing, but please
> use it to identify new BIOS issues.
This is just moving an existing warning, rather than adding a new issue.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2010-02-22 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 21:53 [PATCH] ACPI video: Be more liberal in validating _BQC behaviour Matthew Garrett
2010-02-19 6:40 ` Len Brown
2010-02-19 13:54 ` Matthew Garrett
2010-02-22 1:51 ` Zhang Rui
2010-02-22 2:06 ` Matthew Garrett
2010-02-23 6:29 ` Zhang Rui
2010-02-22 17:24 ` Thomas Renninger
2010-02-22 17:38 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100222173836.GA24808@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.