All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Mike Galbraith" <efault@gmx.de>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Paul Mackerras" <paulus@samba.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: perf sched broken on tip, bisected
Date: Mon, 22 Feb 2010 16:09:52 -0300	[thread overview]
Message-ID: <20100222190952.GD15854@ghostprotocols.net> (raw)
In-Reply-To: <20100222190042.GB15854@ghostprotocols.net>

While testing a patch series I'm working on I noticed that 'perf sched record ;
perf sched latency' is broken on tip, bisected it down to this cset, investigating...

[acme@mica linux-2.6-tip]$ git bisect good
86d8d29634de4464d568e7c335c0da6cba64e8ab is first bad commit
commit 86d8d29634de4464d568e7c335c0da6cba64e8ab
Author: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Date:   Sat Jan 30 20:43:23 2010 +0900

    perf tools: Add __data_loc support
    
    This patch is required to test the next patch for perf lock.
    
    At 064739bc4b3d7f424b2f25547e6611bcf0132415 ,
    support for the modifier "__data_loc" of format is added.
    
    But, when I wanted to parse format of lock_acquired (or some
    event else), raw_field_ptr() did not returned correct pointer.
    
    So I modified raw_field_ptr() like this patch. Then
    raw_field_ptr() works well.
    
    Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
    Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Tom Zanussi <tzanussi@gmail.com>
    Cc: Steven Rostedt <srostedt@redhat.com>
    LKML-Reference: <1264851813-8413-2-git-send-email-mitake@dcl.info.waseda.ac.jp>
    [ v3: fixed minor stylistic detail ]
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

:040000 040000 8650752c9d8295e3c0ae3999b237fb86eb269e5d eb3ecfba6bfbcc80ecde51e10307fefc4d43864e M	tools
[acme@mica linux-2.6-tip]$

(gdb) run sched latency
Starting program: /root/bin/perf sched latency
[Thread debugging using libthread_db enabled]
[Detaching after fork from child process 30314. (Try `set detach-on-fork off'.)]
[New Thread 139670509008608 (LWP 30311)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 139670509008608 (LWP 30311)]
0x000000000040df1b in process_sched_switch_event (data=0x7f079312f9fc, session=0xcaf780, event=0xcaff50, this_cpu=3, timestamp=3964393249899, thread=0xd21ea0) at builtin-sched.c:1489
1489		FILL_ARRAY(switch_event, prev_comm, event, data);
(gdb) bt
#0  0x000000000040df1b in process_sched_switch_event (data=0x7f079312f9fc, session=0xcaf780, event=0xcaff50, this_cpu=3, timestamp=3964393249899, thread=0xd21ea0) at builtin-sched.c:1489
#1  0x000000000040e508 in process_raw_event (raw_event=0x7f079312f9d0, session=0xcaf780, data=0x7f079312f9fc, cpu=3, timestamp=3964393249899, thread=0xd21ea0) at builtin-sched.c:1594
#2  0x000000000040e7ec in process_sample_event (event=0x7f079312f9d0, session=0xcaf780) at builtin-sched.c:1639
#3  0x000000000043be6f in perf_session__process_event (self=0xcaf780, event=0x7f079312f9d0, ops=0x6878e0, offset=0, head=117200) at util/session.c:298
#4  0x000000000043c5f0 in perf_session__process_events (self=0xcaf780, ops=0x6878e0) at util/session.c:464
#5  0x000000000040e8e0 in read_events () at builtin-sched.c:1667
#6  0x000000000040edb7 in __cmd_lat () at builtin-sched.c:1708
#7  0x000000000040f355 in cmd_sched (argc=1, argv=0x7fff2a064640, prefix=0x0) at builtin-sched.c:1911
#8  0x0000000000404fdd in run_builtin (p=0x682cd0, argc=2, argv=0x7fff2a064640) at perf.c:264
#9  0x00000000004051b3 in handle_internal_command (argc=2, argv=0x7fff2a064640) at perf.c:329
#10 0x00000000004052f2 in run_argv (argcp=0x7fff2a064534, argv=0x7fff2a064528) at perf.c:373
#11 0x00000000004054ce in main (argc=2, argv=0x7fff2a064640) at perf.c:457
(gdb)

       reply	other threads:[~2010-02-22 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100222190042.GB15854@ghostprotocols.net>
2010-02-22 19:09 ` Arnaldo Carvalho de Melo [this message]
2010-02-23 13:47   ` perf sched broken on tip, bisected Hitoshi Mitake
2010-02-24  8:03   ` Hitoshi Mitake
2010-02-24  8:04   ` Hitoshi Mitake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100222190952.GD15854@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=efault@gmx.de \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mitake@dcl.info.waseda.ac.jp \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.