From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: kyungmin.park@samsung.com, alsa-devel@alsa-project.org,
Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: Separate dma driver for cpu_dais
Date: Tue, 23 Feb 2010 10:37:08 +0000 [thread overview]
Message-ID: <20100223103708.GB14629@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1b68c6791002222145r543b0e45sfd842d8ddde4280f@mail.gmail.com>
On Tue, Feb 23, 2010 at 02:45:47PM +0900, jassi brar wrote:
> Okay. Here's another perspective ...
> If a dai can have further parallel sub-configurations, perhaps it should
> be further divided into more dais.
> So, I see a snd_soc_dai as the simplest h/w unit in the system and
> presumably already fully exploited by the active dai_link i.e, none of
> its bits can be changed without disturbing the active stream. The
> number of shares should be transparent to a dai.
> If this assumption is valid please read on, otherwise correct me.
That doesn't map too well to hardware - it's relatively rare for devices
to require complete symmetry between the playback and capture portions
of the device, though often there are some constraints. Usually there
is sufficient overlap in the hardware and documentation to describe them
as a single interface but not so much as to force the same configuration
for playback and record.
> The set of {rate, sample size & format, channels} defines one active
> dai. The second stream sharing this dai can not change any of these
> parameters without spoiling the active playback/capture - we can allow
> this configuration overriding as a feature or prevent as a bug. I
> prefer latter. Since there isn't anything new to do now, the ASoC core
> can
> simply avoid calling hooks in drivers rather than having 50 drivers
> implement a check.
If we were to go down this route it'd mean changing the existing drivers
to split their DAIs, which seems like a lot of work and doesn't save us
from having to implement the constraints that do exist. This would be
pretty invasive and I can't clearly see if either approach gives much of
a win in itself.
It seems easier to approach this by providing ways for drivers to
communicate common constraints to the core with things like flags.
That'd at least mean less change for existing code.
next prev parent reply other threads:[~2010-02-23 10:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 2:39 Separate dma driver for cpu_dais jassi brar
2010-02-17 6:58 ` Joonyoung Shim
2010-02-17 7:24 ` jassi brar
2010-02-17 7:37 ` Joonyoung Shim
2010-02-17 10:52 ` Mark Brown
2010-02-17 12:15 ` jassi brar
2010-02-17 13:14 ` Mark Brown
2010-02-18 2:14 ` jassi brar
2010-02-18 9:35 ` Mark Brown
2010-02-18 9:42 ` jassi brar
2010-02-18 9:52 ` Mark Brown
2010-02-18 10:32 ` jassi brar
2010-02-18 10:57 ` Mark Brown
2010-02-18 11:59 ` jassi brar
2010-02-18 13:10 ` Mark Brown
2010-02-23 5:45 ` jassi brar
2010-02-23 10:37 ` Mark Brown [this message]
2010-02-19 9:48 ` jassi brar
2010-02-19 9:50 ` Mark Brown
2010-02-18 6:12 ` Joonyoung Shim
2010-02-18 9:42 ` Mark Brown
2010-02-17 10:42 ` Mark Brown
2010-02-17 12:13 ` jassi brar
2010-02-17 12:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223103708.GB14629@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jassisinghbrar@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.