From: Heiko Voigt <hvoigt@hvoigt.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
msysGit Mailinglist <msysgit@googlegroups.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: Re: [msysGit] [PATCH] submodules: ensure clean environment when operating in a submodule
Date: Tue, 23 Feb 2010 22:07:53 +0100 [thread overview]
Message-ID: <20100223210751.GA10932@book.hvoigt.net> (raw)
In-Reply-To: <alpine.DEB.1.00.1002230103160.3609@intel-tinevez-2-302>
On Tue, Feb 23, 2010 at 01:04:00AM +0100, Johannes Schindelin wrote:
> Hi,
>
> On Mon, 22 Feb 2010, Giuseppe Bilotta wrote:
>
> > git-submodule takes care of clearing GIT_DIR whenever it operates
> > on a submodule index or configuration, but forgot to unset GIT_WORK_TREE
> > before operating on the submodule worktree, which would lead to failures
> > when GIT_WORK_TREE was set.
> >
> > This only happened in very unusual contexts such as operating on the
> > main worktree from outside of it, but since "git-gui: set GIT_DIR and
> > GIT_WORK_TREE after setup" (a9fa11fe5bd5978bb) such failures could also
> > be provoked by invoking an external tool such as "git submodule update"
> > from the Git GUI in a standard setup.
> >
> > Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> > ---
>
> Heiko, would you say that this patch is an elegant solution to the problem
> you reported? If so, would you please pull it to 4msysgit.git's devel?
I would like to leave the patch cooking a little more. For example see
the objection of Jens[1]. Just to be sure that we do not pull in other
issues with this. Sorry I do not have the time for extensive testing
currently. So my suggestion would be to leave msysgit in the current
state as I did not discover any downsides with just the revert with my
current users tests.
As far as I understand the patch fixes issues when submodules itself
contain submodules and it seems that not many users are doing this
currently. Once everybody is happy (and tried) the patches I do not have
any objections to pushing it into devel.
What do you think?
cheers Heiko
[1] http://groups.google.com/group/msysgit/msg/481e252ba4f49ede
next prev parent reply other threads:[~2010-02-23 21:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100218203726.GD12660@book.hvoigt.net>
2010-02-22 22:16 ` [PATCH] submodules: ensure clean environment when operating in a submodule Giuseppe Bilotta
2010-02-22 22:43 ` Junio C Hamano
2010-02-22 22:56 ` Giuseppe Bilotta
2010-02-22 23:16 ` Junio C Hamano
2010-02-22 23:31 ` [PATCH 1/2] shell setup: clear_local_git_env() function Giuseppe Bilotta
2010-02-23 6:49 ` Johannes Sixt
2010-02-23 7:55 ` Giuseppe Bilotta
2010-02-23 8:30 ` [PATCHv2 0/2] clear environment for submodules Giuseppe Bilotta
2010-02-23 8:30 ` [PATCHv2 1/2] shell setup: clear_local_git_env() function Giuseppe Bilotta
2010-02-23 20:25 ` Jens Lehmann
2010-02-23 8:30 ` [PATCHv2 2/2] submodules: ensure clean environment when operating in a submodule Giuseppe Bilotta
2010-02-22 23:31 ` [PATCH " Giuseppe Bilotta
2010-02-23 0:04 ` [msysGit] [PATCH] " Johannes Schindelin
2010-02-23 21:07 ` Heiko Voigt [this message]
2010-02-23 21:47 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223210751.GA10932@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.