From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] cmd_mtdparts.c: prevent printbuffer overflows
Date: Tue, 23 Feb 2010 23:51:23 +0100 [thread overview]
Message-ID: <20100223235123.3a8a9608@wker> (raw)
In-Reply-To: <201002231624.12172.sr@denx.de>
Hi Stefan,
Stefan Roese <sr@denx.de> wrote:
> > - printf("mtdparts: %s\n",
> > - mtdparts_default ? mtdparts_default : "none");
> > + puts("mtdparts: ");
> > + puts(mtdparts_default ? mtdparts_default : "none");
> > + puts("\n");
>
> It might make sense to add a comment here, describing why you use these puts()
> calls instead of one printf(). Otherwise somebody else might trip into this
> problem again in a later time.
This makes sense. I'll add a comment in next patch version.
Best regards,
Anatolij
prev parent reply other threads:[~2010-02-23 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 15:18 [U-Boot] [PATCH v2] cmd_mtdparts.c: prevent printbuffer overflows Anatolij Gustschin
2010-02-23 15:24 ` Stefan Roese
2010-02-23 22:51 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223235123.3a8a9608@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.