All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Richard Colquhoun <arfab@lavabit.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: fix spacing errors and commenting format in r8180_93cx6.c
Date: Tue, 23 Feb 2010 16:42:21 -0800	[thread overview]
Message-ID: <20100224004221.GA27872@kroah.com> (raw)
In-Reply-To: <4B7C0406.9040400@lavabit.com>

> -	ret=0;
> -        //enable EPROM programming
> +	ret = 0;
> +	#enable EPROM programming

This is not valid C.  Please build the code before sending in patches.

Also, you might want to brush up on your C programming skills :)

thanks,

greg k-h

  reply	other threads:[~2010-02-24  0:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 14:58 [PATCH] Staging: rtl8187se: fix spacing errors and commenting format in r8180_93cx6.c Richard Colquhoun
2010-02-24  0:42 ` Greg KH [this message]
2010-03-23  3:52 ` Vikram Dhillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100224004221.GA27872@kroah.com \
    --to=greg@kroah.com \
    --cc=arfab@lavabit.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.