From: Jan Kara <jack@suse.cz>
To: Steven Whitehouse <swhiteho@redhat.com>
Cc: Jan Kara <jack@suse.cz>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: linux-next: build warning after merge of the ext3 tree
Date: Wed, 24 Feb 2010 12:15:24 +0100 [thread overview]
Message-ID: <20100224111524.GC3687@quack.suse.cz> (raw)
In-Reply-To: <20100224105808.GB3687@quack.suse.cz>
On Wed 24-02-10 11:58:11, Jan Kara wrote:
> Hi Stephen,
>
> On Wed 24-02-10 19:05:20, Stephen Rothwell wrote:
> > After merging the ext3 tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > fs/gfs2/quota.c:1581: warning: initialization from incompatible pointer type
> >
> > Introduced by commit ec304a27d7750ba666ad2d446434ddd47fa93c40 ("quota:
> > move code from sync_quota_sb into vfs_quota_sync"). From the commit
> > message, I expect that this has been thought about.
> Thanks for the notification. It seems Christoph missed to convert
> gfs2_quota_sync(). I've now fixed it in a minimalistic way (just added
> the wait parameter to the function).
> Steven (Whitehouse), if GFS2 wants to do something more clever, please
> let me know (or fix up in your tree).
And I had to fixup a few internal callers in GFS2 as well. So Steven, you
might want to have a look at the patch (commit
ef9eb614d974943af3c8eab8ea78a30d5132428c in my linux-fs-2.6 tree).
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-02-24 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 8:05 linux-next: build warning after merge of the ext3 tree Stephen Rothwell
2010-02-24 10:58 ` Jan Kara
2010-02-24 11:15 ` Jan Kara [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-28 10:10 Stephen Rothwell
2021-11-01 11:50 ` Jan Kara
2021-10-28 12:21 Stephen Rothwell
2021-10-28 21:05 ` Gabriel Krisman Bertazi
2021-11-01 11:45 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224111524.GC3687@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.