All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
Cc: phil@ipom.com, usb-storage@lists.one-eyed-alien.net,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [usb-storage] [PATCH] [resend] unusual_devs.h: Fix capacity for SL11R-IDE 2.6c
Date: Wed, 24 Feb 2010 22:22:18 +0100	[thread overview]
Message-ID: <201002242222.21008.linux@rainbow-software.org> (raw)
In-Reply-To: <20100224192959.GJ20232@one-eyed-alien.net>

On Wednesday 24 February 2010 20:29:59 Matthew Dharm wrote:
> On Wed, Feb 24, 2010 at 11:41:08AM +0100, Ondrej Zary wrote:
> > SL11R-IDE 2.6c (at least) reports wrong capacity (one sector more).
> > Reading that last sector causes the device not to work anymore (and looks
> > like HAL or something does that automatically after plugging in):
> > sd 5:0:0:0: [sdc] Device not ready
> > sd 5:0:0:0: [sdc] Result: hostbyte=0x00 driverbyte=0x08
> > sd 5:0:0:0: [sdc] Sense Key : 0x2 [current]
> > sd 5:0:0:0: [sdc] ASC=0x0 ASCQ=0x0
> > sd 5:0:0:0: [sdc] CDB: cdb[0]=0x28: 28 00 04 a8 b5 70 00 00 01 00
> >
> > Add unusual_devs entry to fix the capacity.
>
> Why not just adjust the version range of the entry above where you added a
> new one?

Because that entry fixes IDENTIFY. My version does not seem to have any 
problems with IDENTIFY. Or maybe it has but kernel can now handle it 
automatically:
usb 1-1: new full speed USB device using uhci_hcd and address 4
usb 1-1: configuration #1 chosen from 1 choice
scsi5 : SCSI emulation for USB Mass Storage devices
usb-storage: device found at 4
usb-storage: waiting for device to settle before scanning
scsi scan: INQUIRY result too short (5), using 36
scsi 5:0:0:0: Direct-Access     WDC WD40 0BB-00AUA1       18.2 PQ: 0 ANSI: 1
sd 5:0:0:0: Attached scsi generic sg3 type 0


> If you just expand the upper version of the previous entry, it should cover
> both devices.
>
> Matt



-- 
Ondrej Zary

  reply	other threads:[~2010-02-24 21:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 10:41 [PATCH] [resend] unusual_devs.h: Fix capacity for SL11R-IDE 2.6c Ondrej Zary
2010-02-24 19:29 ` [usb-storage] " Matthew Dharm
2010-02-24 21:22   ` Ondrej Zary [this message]
2010-02-24 22:47     ` Matthew Dharm
2010-02-27 19:11       ` Phil Dibowitz
2010-02-27 20:33         ` Matthew Dharm
2010-02-25 19:03 ` Phil Dibowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002242222.21008.linux@rainbow-software.org \
    --to=linux@rainbow-software.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mdharm-kernel@one-eyed-alien.net \
    --cc=phil@ipom.com \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.