From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: alsa-devel@alsa-project.org, Jassi Brar <jassi.brar@samsung.com>,
lrg@slimlogic.co.uk
Subject: Re: [RFC] ASoC: Allow mulitple usage of codec and cpu dai
Date: Thu, 25 Feb 2010 13:06:19 +0000 [thread overview]
Message-ID: <20100225130619.GB11071@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1b68c6791002250300u4c6ff89am5009dc56187be6b1@mail.gmail.com>
On Thu, Feb 25, 2010 at 08:00:13PM +0900, jassi brar wrote:
> On Thu, Feb 25, 2010 at 7:03 PM, Mark Brown
> > I thought I'd been fairly clear last time that the drivers need to have
> > an option to do stuff on startup(). As I said then a separate callback
> > which is called only on the transitions into and out of active would be
> > fine.
> This is simply the patch, that you asked me to dig out from samsung-git
> and post to the list, adapted to for-2.6.35
I asked you to pull out the bits that maintain active.
> I could drop startup,shutdown,mute-on/off as well, but no codec driver
> would work with that as such. If that's ok, i'll resend the patch.
Honestly I didn't read the rest of the patch after I saw the change to
remove the startup() callback. Clearly fiddling around with the active
count isn't going to make every possible system work, and it may not be
any use at all, but so long as it doesn't interfere with other users
it's not really a problem.
As I said previously this should really be being done by showing the
mixer as a device within ASoC rather than this way. Trying to pretend
the mixer isn't there is going to cause problems, the confusion about
when the stream is live being just one of them.
next prev parent reply other threads:[~2010-02-25 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 4:26 [RFC] ASoC: Allow mulitple usage of codec and cpu dai Jassi Brar
2010-02-25 10:03 ` Mark Brown
2010-02-25 11:00 ` jassi brar
2010-02-25 13:06 ` Mark Brown [this message]
2010-02-26 0:32 ` jassi brar
2010-02-26 11:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225130619.GB11071@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jassi.brar@samsung.com \
--cc=jassisinghbrar@gmail.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.