From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] xen: fbdev frontend needs xenbus frontend Date: Thu, 25 Feb 2010 12:48:08 -0500 Message-ID: <20100225174808.GB13270@phenom.dumpdata.com> References: <20100224135828.GA32009@wavehammer.waldi.eu.org> <20100225124047.GA9040@phenom.dumpdata.com> <4B86B562.4030009@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4B86B562.4030009@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: Bastian Blank , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, Feb 25, 2010 at 09:37:38AM -0800, Jeremy Fitzhardinge wrote: > On 02/25/2010 04:40 AM, Konrad Rzeszutek Wilk wrote: >> On Wed, Feb 24, 2010 at 02:58:28PM +0100, Bastian Blank wrote: >> >>> The fbdev (and kbddev) frontend needs the xenbus frontend, but does not >>> define a dependency. Make the fbdev frontend select the xenbus >>> frontend. >>> >> Isn't this the same as ba69ea42f8ba8286cbe0e939bd1ce781b7905b84? If so >> (and if the above mention commit isn't in xen/next) >> shouldn't you also make this change for drives/input/Kconfig for >> XEN_KBDDEV_FRONTEND? >> > > Did that end up in .33? Should we put it in -stable too? I took a look at the code and I think Bastian's is OK. The -stable has this: 152 config XEN_KBDDEV_FRONTEND 153 tristate "Xen virtual keyboard and mouse support" 154 depends on XEN_FBDEV_FRONTEND 155 default y So it would end up selecting the xenbus frontend as well with Bastian's patch.