From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Neil Horman <nhorman@tuxdriver.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH -mm 0/2] umh && creds: kill sub_info->cred
Date: Thu, 25 Feb 2010 19:14:54 +0100 [thread overview]
Message-ID: <20100225181454.GA18000@redhat.com> (raw)
(on top of kmod-replace-call_usermodehelper_pipe-with-use-of-umh-init-function-and-resolve-limit.patch)
David, all.
I was going to do some minor fixes in kmod.c, but looking at this
code I am really puzzled by subprocess_info->cred complications.
I know absoulutely nothing about creds/keys, but at first glance
this all looks completely unnecessary?
IOW, please review these 2 simple patches. And sorry, I have no
idea how to really test these changes.
In case you are not aware of recent call_usermodehelper() changes
in -mm: struct subprocess_info has the new members,
int (*init)(struct subprocess_info *info);
void (*cleanup)(struct subprocess_info *info);
void *data;
info->init() is called by ____call_usermodehelper() right before kernel_execve(),
info->cleanup() is called by call_usermodehelper_freeinfo().
info->data is obvious.
And we have the new helper, call_usermodehelper_setfns(init, cleanup, data)
which merely initializes these members.
Oleg.
next reply other threads:[~2010-02-25 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 18:14 Oleg Nesterov [this message]
2010-02-26 15:24 ` [PATCH -mm 0/2] umh && creds: kill sub_info->cred David Howells
2010-02-26 16:33 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225181454.GA18000@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.