All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Li Zefan <lizf@cn.fujitsu.com>,
	Wenji Huang <wenji.huang@oracle.com>
Subject: [PATCH 7/7] tracing: Simplify memory recycle of trace_define_field
Date: Thu, 25 Feb 2010 14:44:02 -0500	[thread overview]
Message-ID: <20100225194530.242648627@goodmis.org> (raw)
In-Reply-To: 20100225194355.707261669@goodmis.org

[-- Attachment #1: 0007-tracing-Simplify-memory-recycle-of-trace_define_fiel.patch --]
[-- Type: text/plain, Size: 825 bytes --]

From: Wenji Huang <wenji.huang@oracle.com>

Discard freeing field->type since it is not necessary.

Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Wenji Huang <wenji.huang@oracle.com>
LKML-Reference: <1266997226-6833-5-git-send-email-wenji.huang@oracle.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/trace_events.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index c2a3077..3f972ad 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -60,10 +60,8 @@ int trace_define_field(struct ftrace_event_call *call, const char *type,
 	return 0;
 
 err:
-	if (field) {
+	if (field)
 		kfree(field->name);
-		kfree(field->type);
-	}
 	kfree(field);
 
 	return -ENOMEM;
-- 
1.6.5



  parent reply	other threads:[~2010-02-25 19:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 19:43 [PATCH 0/7][GIT PULL] tracing: updates Steven Rostedt
2010-02-25 19:43 ` [PATCH 1/7] ftrace: Remove memory barriers from NMI code when not needed Steven Rostedt
2010-02-25 19:43 ` [PATCH 2/7] tracing: Fix ftrace_event_call alignment for use with gcc 4.5 Steven Rostedt
2010-02-25 19:43 ` [PATCH 3/7] tracing: Remove CONFIG_TRACE_POWER from kernel config Steven Rostedt
2010-02-25 19:43 ` [PATCH 4/7] tracing: Fix typo in prof_sysexit_enable() Steven Rostedt
2010-02-25 19:44 ` [PATCH 5/7] tracing: Fix typo of info text in trace_kprobe.c Steven Rostedt
2010-02-25 19:44 ` [PATCH 6/7] tracing: Remove unnecessary variable in print_graph_return Steven Rostedt
2010-02-25 19:44 ` Steven Rostedt [this message]
2010-02-26  8:21 ` [PATCH 0/7][GIT PULL] tracing: updates Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100225194530.242648627@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=wenji.huang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.