From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/7] drivers/net/chelsio: Use pr_<level>, netif_msg_<type>
Date: Fri, 26 Feb 2010 01:40:10 -0800 (PST) [thread overview]
Message-ID: <20100226.014010.239722623.davem@davemloft.net> (raw)
In-Reply-To: <819e937a3feefb278c2816db2947eff95dd6740a.1266893507.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 22 Feb 2010 18:56:57 -0800
> Convert CH_<level> and CH_DBG uses to pr_<level> and netif equivalents
> Remove CH_<level> and CH_DBG macro definitions
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks Joe.
BTW:
> @@ -734,8 +734,9 @@ int t1_elmer0_ext_intr_handler(adapter_t *adapter)
> break;
> case CHBT_BOARD_8000:
> case CHBT_BOARD_CHT110:
> - CH_DBG(adapter, INTR, "External interrupt cause 0x%x\n",
> - cause);
> + if (netif_msg_intr(adapter))
> + dev_dbg(&adapter->pdev->dev,
Trailing whitespace on that last line. I fixed it up when
adding the patch to my tree.
next prev parent reply other threads:[~2010-02-26 9:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 2:56 [PATCH net-next 0/7] drivers/net conversions to netdev_<level>, etc Joe Perches
2010-02-23 2:56 ` Joe Perches
2010-02-23 2:56 ` [PATCH net-next 1/7] drivers/net/chelsio: Use pr_<level>, netif_msg_<type> Joe Perches
2010-02-26 9:40 ` David Miller [this message]
2010-02-23 2:56 ` [PATCH net-next 2/7] drivers/net/myri10ge: Use pr_<level> and netdev_<level> Joe Perches
2010-02-26 9:40 ` David Miller
2010-02-23 2:56 ` [PATCH net-next 3/7] drivers/net/ixgbe: Use pr_<level> and netif_<level> Joe Perches
2010-02-23 2:56 ` Joe Perches
2010-02-23 2:57 ` [PATCH net-next 4/7] drivers/net/ixgb: Use pr_<level> and netdev_<level> Joe Perches
2010-02-23 2:57 ` Joe Perches
2010-02-23 2:57 ` [PATCH net-next 5/7] drivers/net/e1000: Use pr_<level> and netif_<level> Joe Perches
2010-02-23 2:57 ` Joe Perches
2010-02-23 2:57 ` [PATCH net-next 6/7] drivers/net/e1000e: Use pr_<level> and netdev_<level> Joe Perches
2010-02-23 2:57 ` Joe Perches
2010-02-23 19:17 ` Allan, Bruce W
2010-02-23 19:17 ` Allan, Bruce W
2010-02-23 2:57 ` [PATCH net-next 7/7] drivers/net/igb: Use netdev_<level> Joe Perches
2010-02-23 2:57 ` Joe Perches
2010-02-24 2:33 ` [PATCH net-next 0/7] drivers/net conversions to netdev_<level>, etc Jeff Kirsher
2010-02-24 2:33 ` Jeff Kirsher
2010-03-01 21:16 ` [PATCH net-next] drivers/net/e100.c: Use pr_<level> and netif_<level> Joe Perches
2010-03-17 4:31 ` David Miller
2010-03-17 4:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100226.014010.239722623.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.