Re: [net-next-2.6 PATCH] net: convert multiple drivers to use netdev_for_each_mc_addr, part5 V2

[Jiri Pirko <jpirko@redhat.com>]

Fri, Feb 26, 2010 at 11:03:33AM CET, davem@davemloft.net wrote:
>
>100 EURO says you didn't compile test this.
>
>@@ -975,7 +968,7 @@ static void do_set_multicast_list(struct net_device *dev)
> 
>   	if(dev->flags&IFF_PROMISC)
>   		ei_outb_p(E8390_RXCONFIG | 0x18, e8390_base + EN0_RXCR);
>-	else if(dev->flags&IFF_ALLMULTI || dev->mc_list)
>+	else if (dev->flags & IFF_ALLMULTI || !netdev_mc_addr(dev))
>   		ei_outb_p(E8390_RXCONFIG | 0x08, e8390_base + EN0_RXCR);
>   	else
>   		ei_outb_p(E8390_RXCONFIG, e8390_base + EN0_RXCR);
>
>I'll fix it up, but you have to start getting proper build
>coverage of your patches!
>
>I really don't care how slow your netbook is, this case could have
>been easily prevented.

I'm really sorry, I do compile test all my patches, but I must have missed this
:(

I promise I'll reserve 2xtime next time. You'll have a beer on me :)

Jirka